From: Mark Walters Date: Thu, 22 Nov 2012 18:46:44 +0000 (+0000) Subject: Re: [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' clickable X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=b2283a518723fe9d074f8aa8b9278ba65e43cd85;p=notmuch-archives.git Re: [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' clickable --- diff --git a/56/f4c147d7cf0474b03a21228a6db493744ea556 b/56/f4c147d7cf0474b03a21228a6db493744ea556 new file mode 100644 index 000000000..c0fce50ba --- /dev/null +++ b/56/f4c147d7cf0474b03a21228a6db493744ea556 @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A4006431FBD + for ; Thu, 22 Nov 2012 10:46:51 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9TPE+G0FjyCR for ; + Thu, 22 Nov 2012 10:46:48 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E3EC4431FAF + for ; Thu, 22 Nov 2012 10:46:47 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1TbbnP-0004AU-NE; Thu, 22 Nov 2012 18:46:44 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1TbbnP-0000e0-CV; Thu, 22 Nov 2012 18:46:43 +0000 +From: Mark Walters +To: Damien Cassou +Subject: Re: [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' + clickable +In-Reply-To: + +References: <1353266322-20318-1-git-send-email-damien.cassou@gmail.com> + <1353266322-20318-4-git-send-email-damien.cassou@gmail.com> + <87a9uepl2t.fsf@qmul.ac.uk> + +User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 22 Nov 2012 18:46:44 +0000 +Message-ID: <87sj81jx0r.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 8631c7536e76f81abf8fba82e657e713 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +Cc: notmuch mailing list +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 22 Nov 2012 18:46:51 -0000 + + +On Thu, 22 Nov 2012, Damien Cassou wrote: +> Hi, +> +> On Mon, Nov 19, 2012 at 12:06 AM, Mark Walters wrote: +> +>> This patch adds buttons for every tag in show mode which means that +>> tabbing down to an attachment (or other button) is rather slower. As +>> someone who is not going to use the tag buttons (at least not very +>> often) Is it possible to avoid this? perhaps by making the button +>> optional or making the button only mouse clickable? (Since the buttons +>> in the headerline are not tabbable to then the latter might be +>> reasonable.) +>> +> +> you are perfectly right. In the upcoming patch I made the buttons so that +> TAB won't stop at them ('skip t) but you can still activate them with RET +> or a mouse click. Is that ok? + +That sounds perfect. + +Many thanks for all the work! + +Mark + +> +> -- +> Damien Cassou +> http://damiencassou.seasidehosting.st +> +> "Success is the ability to go from one failure to another without losing +> enthusiasm." +> Winston Churchill