From: Jameson Graef Rollins Date: Sun, 8 Apr 2012 00:35:30 +0000 (+1700) Subject: emacs tagging cleanup X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=aea68495ff14202b19a2bff1d7de0bb21dae44de;p=notmuch-archives.git emacs tagging cleanup --- diff --git a/60/8e019601e4376ef42ec1124dca08d2527322e1 b/60/8e019601e4376ef42ec1124dca08d2527322e1 new file mode 100644 index 000000000..711f19e20 --- /dev/null +++ b/60/8e019601e4376ef42ec1124dca08d2527322e1 @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 9DD66431FDA + for ; Sat, 7 Apr 2012 17:35:51 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id zKBrW+pJEgBY for ; + Sat, 7 Apr 2012 17:35:50 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id BA7A1431FD2 + for ; Sat, 7 Apr 2012 17:35:47 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 49E3966E00DB + for ; Sat, 7 Apr 2012 17:35:45 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (unknown [76.89.193.65]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 6A86766E00E1 + for ; Sat, 7 Apr 2012 17:35:43 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id EC9424EF; Sat, 7 Apr 2012 17:35:42 -0700 (PDT) +From: Jameson Graef Rollins +To: Notmuch Mail +Subject: emacs tagging cleanup +Date: Sat, 7 Apr 2012 17:35:30 -0700 +Message-Id: <1333845338-22960-1-git-send-email-jrollins@finestructure.net> +X-Mailer: git-send-email 1.7.9.1 +In-Reply-To: <1333354853-25729-1-git-send-email-jrollins@finestructure.net> +References: <1333354853-25729-1-git-send-email-jrollins@finestructure.net> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 08 Apr 2012 00:35:52 -0000 + +This is a rework of the series [0]. It addresses some of the comments +from Dmitry, and extends the scope to clean up the tagging interface +in both search and show mode. + +[0] id:"1333354853-25729-1-git-send-email-jrollins@finestructure.net" + +The goal here is to present a cleaner tagging interface to the user. +We want things to be simple, not confusing or redundant. To that end +I have extended the notmuch-tag function to handle prompting if +needed. The main user-facing functions are now: + + notmuch-search-tag tag thread or region + notmuch-search-tag-all tag all thread in search buffer + notmuch-show-tag tag message + notmuch-show-tag-all tag all message in show buffer + +I think this provides a much cleaner interface that is more useful to +users. In particular, this improves the ability to tag regions in +search mode. + +I have eliminated two user-facing functions (notmuch-search-tag-thread +and notmuch-show-tag-message) since they are now redundant. This +might cause a slight hiccup for those using those functions, but I +think it's better in the long run. + +Unfortunately something in the last patch (last two patches, I guess) +is now causing a two of our more esoteric tests to fail. After +spending half the day trying to figure out why I'm at a loss. And I +don't want all this work to be wasted so I'm submitting it anyway. +Hopefully someone (maybe the creator of those tests?) can figure out +what's going on. + +jamie. +