From: Pieter Praet Date: Wed, 1 Feb 2012 20:35:26 +0000 (+0100) Subject: Re: emacs: quote MML tags in replies X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=ac5d103fa9805e70403d4614ef7d12af25d8fc09;p=notmuch-archives.git Re: emacs: quote MML tags in replies --- diff --git a/6d/d04cadb33d5ba78f7b7a9e9016a5134ad39c5b b/6d/d04cadb33d5ba78f7b7a9e9016a5134ad39c5b new file mode 100644 index 000000000..8b2db2dfe --- /dev/null +++ b/6d/d04cadb33d5ba78f7b7a9e9016a5134ad39c5b @@ -0,0 +1,147 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id DB801431FAF + for ; Wed, 1 Feb 2012 12:37:25 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nb2ESdGolk3p for ; + Wed, 1 Feb 2012 12:37:25 -0800 (PST) +Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com + [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 03574431FAE + for ; Wed, 1 Feb 2012 12:37:24 -0800 (PST) +Received: by wibhi8 with SMTP id hi8so1320789wib.26 + for ; Wed, 01 Feb 2012 12:37:22 -0800 (PST) +Received: by 10.180.24.105 with SMTP id t9mr99507wif.19.1328128642555; + Wed, 01 Feb 2012 12:37:22 -0800 (PST) +Received: from localhost ([109.131.39.11]) + by mx.google.com with ESMTPS id q2sm35342124wiy.7.2012.02.01.12.37.21 + (version=TLSv1/SSLv3 cipher=OTHER); + Wed, 01 Feb 2012 12:37:21 -0800 (PST) +From: Pieter Praet +To: Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: emacs: quote MML tags in replies +In-Reply-To: <87d39ymyb4.fsf@gmail.com> +References: <1326998589-37187-1-git-send-email-aaronecay@gmail.com> + <1328064581-13949-1-git-send-email-dmitry.kurochkin@gmail.com> + <87vcnq64ra.fsf@praet.org> <87d39ymyb4.fsf@gmail.com> +User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +Date: Wed, 01 Feb 2012 21:35:26 +0100 +Message-ID: <87ipjqb8c1.fsf@praet.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 01 Feb 2012 20:37:26 -0000 + +On Wed, 01 Feb 2012 18:18:55 +0400, Dmitry Kurochkin wrote: +> On Wed, 01 Feb 2012 14:51:37 +0100, Pieter Praet wrote: +> > On Wed, 1 Feb 2012 06:49:39 +0400, Dmitry Kurochkin wrote: +> > > Hi Aaron. +> > > +> > > Thanks for your work! I took the liberty to do some cleanups for your +> > > patch. Below is a detailed list of changes. +> > > +> > +> > Thanks to the both of you! +> > +> > +> > > Hope this helps. +> > > +> > > Changes since v2: +> > > +> > > * change patch names to be consistent with others: +> > > +> > > - s/emacs:/test:/ for the test patch +> > > +> > > - lower case the first word after colon in the patch title +> > > +> > > * polish NEWS wording, move it to 0.12 section +> > > +> > > * add comment to `mml-quote-region' call, as suggested by Tomi [1] +> > > +> > > * fix and clean up the test: +> > > +> > > - set `notmuch-fcc-dirs' to nil to avoid adding the Fcc header, +> > > otherwise it breaks the test on other systems as pointed by +> > > David [2] +> > > +> > +> > Could also have been avoided by adding the expected result inline, +> > and using "Fcc: $(pwd)/mail/sent". I'll send an updated patch to +> > that effect. +> > +> +> I do not understand how this is better. [...] + +Well, the expected output is only 7 lines, so we might as well keep it +inside the test itself (of which the advantages need no reiteration), +and doing so would allow us to get the Fcc path in a more future-proof way; +`notmuch-fcc-dirs' is more susceptible to deprecation than $MAIL_DIR et al. + + +> [...] But please do not use $(pwd) +> here. I know that other tests do that in the same case, but it is +> wrong. There is $MAIL_DIR variable for this. See "notmuch-fcc-dirs set +> to a string" test for an example. +> + +Good point! Patch follows. + + +> Regards, +> Dmitry +> +> > +> > > - use default values for add_message parameters where possible +> > > +> > > - use a sane subject value in add_message +> > > +> > > - use shorter MML tag as produced by (mml-insert-part) +> > > +> > > - indenting and other minor cleanups +> > > +> > > Regards, +> > > Dmitry +> > > +> > > [1] id:"m2wr89ioos.fsf@guru.guru-group.fi" +> > > [2] id:"87ehugzycb.fsf@zancas.localnet" +> > > +> > > _______________________________________________ +> > > notmuch mailing list +> > > notmuch@notmuchmail.org +> > > http://notmuchmail.org/mailman/listinfo/notmuch +> > +> > Despite my comment re Fcc, both LGTM. +> > +> > +> > Peace +> > +> > -- +> > Pieter + + +Peace + +-- +Pieter