From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sat, 27 Oct 2012 12:13:58 +0000 (+0300)
Subject: Re: [PATCH 0/3] Add notmuch-pick to contrib
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=ab91bb5a47e34ba8850b3122544737570ba717cd;p=notmuch-archives.git

Re: [PATCH 0/3] Add notmuch-pick to contrib
---

diff --git a/45/51323ed8fa1aa7799168040fa9186efa0479da b/45/51323ed8fa1aa7799168040fa9186efa0479da
new file mode 100644
index 000000000..a18c003d3
--- /dev/null
+++ b/45/51323ed8fa1aa7799168040fa9186efa0479da
@@ -0,0 +1,98 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id AF713431E82
+	for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 05:13:56 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id BMYAE1Mzd67C for <notmuch@notmuchmail.org>;
+	Sat, 27 Oct 2012 05:13:56 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 3AAD7431FAF
+	for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 05:13:56 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 38299100045;
+	Sat, 27 Oct 2012 15:13:58 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 0/3] Add notmuch-pick to contrib
+In-Reply-To: <1351337200-18050-1-git-send-email-markwalters1009@gmail.com>
+References: <1351337200-18050-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.14+59~gf9031cd (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sat, 27 Oct 2012 15:13:58 +0300
+Message-ID: <m28vasqfi1.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 27 Oct 2012 12:13:56 -0000
+
+On Sat, Oct 27 2012, Mark Walters <markwalters1009@gmail.com> wrote:
+
+> This is a new version of notmuch-pick (previous version at
+> id:"1343164911-31589-1-git-send-email-markwalters1009@gmail.com")following
+> suggestions of Tomi and David in that thread. The main change is that
+> it is now entirely self contained in contrib: all the user needs to do
+> is copy the notmuch-pick.el somewhere in the emacs load path and add
+> (require 'notmuch-pick nil t) to their .emacs file.
+>
+> The other changes are that I think I have fixed both of the bugs that
+> David found.
+>
+> In the longer term I would like to get pick into mainline. I think the
+> steps are: first remove code duplication, improve lisp idioms and fix
+> any bugs that are found; then move pick into the main .emacs directory
+> but still require the user to "require" it. Finally when people are
+> happy with the code enable it by default.
+
+This is a nice piece of contrib software. LGTM.
+
+Tomi
+
+>
+> Best wishes
+>
+> Mark
+>
+>
+> Mark Walters (3):
+>   contrib: add notmuch-pick.el file itself
+>   contrib: add pick README.
+>   contrib: add pick TODO file
+>
+>  contrib/notmuch-pick/README          |   38 ++
+>  contrib/notmuch-pick/TODO            |   29 ++
+>  contrib/notmuch-pick/notmuch-pick.el |  867 ++++++++++++++++++++++++++++++++++
+>  3 files changed, 934 insertions(+), 0 deletions(-)
+>  create mode 100644 contrib/notmuch-pick/README
+>  create mode 100644 contrib/notmuch-pick/TODO
+>  create mode 100644 contrib/notmuch-pick/notmuch-pick.el
+>
+> -- 
+> 1.7.9.1
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch