From: Adrien Bustany Date: Thu, 25 Oct 2012 18:41:33 +0000 (+0300) Subject: Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=aad643da812618ca2442e9ef6d4e5742e724a656;p=notmuch-archives.git Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected --- diff --git a/62/10f4157dec07a7c04852d623a18c01d1bdc663 b/62/10f4157dec07a7c04852d623a18c01d1bdc663 new file mode 100644 index 000000000..383154e50 --- /dev/null +++ b/62/10f4157dec07a7c04852d623a18c01d1bdc663 @@ -0,0 +1,82 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 9A3BE431FC0 + for ; Thu, 25 Oct 2012 11:41:37 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id xAD6SFFjUq1j for ; + Thu, 25 Oct 2012 11:41:37 -0700 (PDT) +Received: from mail.bustany.org (bustany.org [176.31.244.208]) + by olra.theworths.org (Postfix) with ESMTP id 2885F431FAE + for ; Thu, 25 Oct 2012 11:41:37 -0700 (PDT) +Received: from [192.168.1.147] (91-158-5-86.elisa-laajakaista.fi + [91.158.5.86]) by mail.bustany.org (Postfix) with ESMTPSA id 3DCAE140230; + Thu, 25 Oct 2012 20:45:31 +0200 (CEST) +Message-ID: <508987DD.9010405@bustany.org> +Date: Thu, 25 Oct 2012 21:41:33 +0300 +From: Adrien Bustany +User-Agent: Mozilla/5.0 (X11; Linux x86_64; + rv:16.0) Gecko/20121009 Thunderbird/16.0 +MIME-Version: 1.0 +To: Ethan Glasser-Camp +Subject: Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected +References: <1342636475-16057-1-git-send-email-adrien@bustany.org> + <1342636475-16057-4-git-send-email-adrien@bustany.org> + <87wqyn6rpf.fsf@betacantrips.com> +In-Reply-To: <87wqyn6rpf.fsf@betacantrips.com> +Content-Type: text/plain; charset=ISO-8859-1; format=flowed +Content-Transfer-Encoding: 8bit +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 25 Oct 2012 18:41:37 -0000 + +Le 19/10/2012 06:55, Ethan Glasser-Camp a écrit : +> Adrien Bustany writes: +> +>> This makes notmuch appropriately free the underlying notmuch C objects +>> when garbage collecting their Go wrappers. To make sure we don't break +>> the underlying links between objects (for example, a notmuch_messages_t +>> being GC'ed before a notmuch_message_t belonging to it), we add for each +>> wraper struct a pointer to the owner object (Go objects with a reference +>> pointing to them don't get garbage collected). +> +> Hi Adrien! This whole series is marked moreinfo, but I don't think +> that's just. It looks like there were some unresolved issues about +> reference tracking and garbage collection, and some suggestions to use +> the C values of enums instead of regenerating them with iota, but +> there's definitely valid code that I assume would be useful if anyone +> ever wanted to write in Go ;). Are you figuring to clean this series up? +> +> This comment should s/wraper/wrapper/. +> +> Ethan +> + +Hello Ethan, + +thanks for the heads up, I still have this on my table, and yes there is +additional work to do for the patches to be really clean. I can't give +an estimate for now, let's hope sooner than later :/ + +Cheers + +Adrien