From: Dmitry Kurochkin Date: Tue, 17 Apr 2012 09:06:13 +0000 (+0400) Subject: Re: [RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=a9e77e52cd69d7c5840e4ff70be2b73c6e76da85;p=notmuch-archives.git Re: [RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook --- diff --git a/bd/760820123d78aedaa1e7183a32f09b12c2824b b/bd/760820123d78aedaa1e7183a32f09b12c2824b new file mode 100644 index 000000000..99ec08c7c --- /dev/null +++ b/bd/760820123d78aedaa1e7183a32f09b12c2824b @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6D9BA431FB6 + for ; Tue, 17 Apr 2012 02:08:07 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id SMmXMXNUMQei for ; + Tue, 17 Apr 2012 02:08:05 -0700 (PDT) +Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com + [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 398B4431FAE + for ; Tue, 17 Apr 2012 02:08:05 -0700 (PDT) +Received: by lbdb5 with SMTP id b5so1761034lbd.26 + for ; Tue, 17 Apr 2012 02:08:03 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=WxWVIB6MDAbxOqoNcm1cC2OPFsASXhHiFAZTMLnCzQ0=; + b=bcJMQQ5bIA2Vjpxt+QaGKUisyB57ZFiBNJXWb+nqdxatJ20ik4MW+WfOLRmAFtSGKr + LaKn3O9cXmWS55NL+LUeca2d0D+tw5fMYGJ429sRhBB9jt1hwaYWgXjirFotwFsW9ENp + QPLtiSGFIxZKGkMwN57/p2z7ZFAyiJ9SD6TaCs9Ok8nLKBNDr0ArB02LWZVNX5FpWfE6 + EHQBKWIxfJCtbn/MJyhTyLKKhYgi/37A5qPUl45P+RoiwzYS73nMWirVL4kqryNoSna5 + dOQ4mk7aJPuv4tbEJujgRnIytrk4CAqy9ELFcqgcvLHh0ABDB3PU1C0Ay1EesSz7uXYx + w+lA== +Received: by 10.152.127.136 with SMTP id ng8mr13435851lab.16.1334653683544; + Tue, 17 Apr 2012 02:08:03 -0700 (PDT) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id mm11sm22203862lab.2.2012.04.17.02.08.02 + (version=TLSv1/SSLv3 cipher=OTHER); + Tue, 17 Apr 2012 02:08:02 -0700 (PDT) +From: Dmitry Kurochkin +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [RFC PATCH 2/4] emacs: add no-display arg to + notmuch-hello-refresh-hook +In-Reply-To: + <21f129a3426c58d44fed7150b32c4fec7021bda0.1334651669.git.jani@nikula.org> +References: + + <21f129a3426c58d44fed7150b32c4fec7021bda0.1334651669.git.jani@nikula.org> +User-Agent: Notmuch/0.12+104~gf9ad237 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 17 Apr 2012 13:06:13 +0400 +Message-ID: <877gxeohh6.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 17 Apr 2012 09:08:07 -0000 + +Can you please give some explanaition why is this needed? Would this +change break custom hooks that do not expect any arguments? + +Regards, + Dmitry + +Jani Nikula writes: + +> --- +> emacs/notmuch-hello.el | 2 +- +> 1 files changed, 1 insertions(+), 1 deletions(-) +> +> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el +> index 9cd907a..0596bbe 100644 +> --- a/emacs/notmuch-hello.el +> +++ b/emacs/notmuch-hello.el +> @@ -776,7 +776,7 @@ following: +> (widget-setup) +> +> (goto-char final-target-pos)) +> - (run-hooks 'notmuch-hello-refresh-hook) +> + (run-hook-with-args 'notmuch-hello-refresh-hook no-display) +> (setq notmuch-hello-first-run nil)) +> +> (defun notmuch-folder () +> -- +> 1.7.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch