From: Ian Abbott <abbotti@mev.co.uk>
Date: Mon, 9 Feb 2009 16:32:12 +0000 (+0000)
Subject: Fix GCC warning in call to request_module(): "format not a string literal
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=a94c5ccfed669bcfaa7cdbffb46543cd0a7e49ce;p=comedi.git

Fix GCC warning in call to request_module(): "format not a string literal
and no format arguments".
---

diff --git a/comedi/comedi_fops.c b/comedi/comedi_fops.c
index 8e976a6d..7fc40ca1 100644
--- a/comedi/comedi_fops.c
+++ b/comedi/comedi_fops.c
@@ -1754,7 +1754,6 @@ void do_become_nonbusy(comedi_device * dev, comedi_subdevice * s)
 
 static int comedi_open(struct inode *inode, struct file *file)
 {
-	char mod[32];
 	const unsigned minor = iminor(inode);
 	struct comedi_device_file_info *dev_file_info = comedi_get_device_file_info(minor);
 	comedi_device *dev = dev_file_info->device;
@@ -1789,10 +1788,9 @@ static int comedi_open(struct inode *inode, struct file *file)
 
 	dev->in_request_module = 1;
 
-	sprintf(mod, "char-major-%i-%i", COMEDI_MAJOR, dev->minor);
 #ifdef CONFIG_KMOD
 	mutex_unlock(&dev->mutex);
-	request_module(mod);
+	request_module("char-major-%i-%i", COMEDI_MAJOR, dev->minor);
 	mutex_lock(&dev->mutex);
 #endif