From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Mon, 24 Sep 2012 12:50:50 +0000 (+0200) Subject: Re: RFC: Annotate internal_error with the attribute noreturn 2nd patchset X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=a5ce1a4e633dadb8328d3fd09e0eb6720a782a4e;p=notmuch-archives.git Re: RFC: Annotate internal_error with the attribute noreturn 2nd patchset --- diff --git a/06/bc197d52d73730ebb358a1bbf44521a7a1fb7c b/06/bc197d52d73730ebb358a1bbf44521a7a1fb7c new file mode 100644 index 000000000..4bd29442f --- /dev/null +++ b/06/bc197d52d73730ebb358a1bbf44521a7a1fb7c @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 693FE431FC0 + for ; Mon, 24 Sep 2012 05:50:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id cjWjcAwjkWnw for ; + Mon, 24 Sep 2012 05:50:56 -0700 (PDT) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D70E5431FAF + for ; Mon, 24 Sep 2012 05:50:55 -0700 (PDT) +Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id 73E375AB11A + for ; Mon, 24 Sep 2012 14:50:54 +0200 (CEST) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id D7BABDF2A4; Mon, 24 Sep 2012 14:50:53 +0200 (CEST) +Received: from thinkbox.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) (Authenticated sender: teythoon) + by mail.jade-hamburg.de (Postfix) with ESMTPSA id 23D07DF2A1; + Mon, 24 Sep 2012 14:50:51 +0200 (CEST) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.80) + (envelope-from ) + id 1TG87e-0003gU-Az; Mon, 24 Sep 2012 14:50:50 +0200 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: quoted-printable +From: Justus Winter <4winter@informatik.uni-hamburg.de> +User-Agent: alot/0.3.3+ +To: David Bremner , notmuch@notmuchmail.org +References: <20120922161256.GE26662@mit.edu> + <1348482717-10340-1-git-send-email-4winter@informatik.uni-hamburg.de> + <873927hf9n.fsf@zancas.localnet> +In-Reply-To: <873927hf9n.fsf@zancas.localnet> +Message-ID: <20120924125050.13910.66110@thinkbox.jade-hamburg.de> +Subject: Re: RFC: Annotate internal_error with the attribute noreturn 2nd + patchset +Date: Mon, 24 Sep 2012 14:50:50 +0200 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 24 Sep 2012 12:50:56 -0000 + +Quoting David Bremner (2012-09-24 12:44:04) +> Justus Winter <4winter@informatik.uni-hamburg.de> writes: +> = + +> > We need to discuss where those kind of macro definitions abstracting +> > away compiler differences should go. None of the files in util +> > includes notmuch-private.h, so I was unsure whether it's okay to put +> > them there. +> = + +> How about a new header file in util/ +> = + +> function-attributes.h or something like that? +> = + +> The util stuff is "lower level" than lib/ so it makes sense to me to put +> common stuff there. + +Maybe we should add this file to compat? + +Justus