From: David Edmondson Date: Mon, 6 Feb 2012 07:47:38 +0000 (+0000) Subject: Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=a2bf8ceb253dd39d2455369210ca34c88c2dd325;p=notmuch-archives.git Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. --- diff --git a/34/16a2ed3286fbfd13c205e8975cc36d28a50493 b/34/16a2ed3286fbfd13c205e8975cc36d28a50493 new file mode 100644 index 000000000..af6e53d7b --- /dev/null +++ b/34/16a2ed3286fbfd13c205e8975cc36d28a50493 @@ -0,0 +1,109 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5B7CF431FAF + for ; Sun, 5 Feb 2012 23:47:49 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id qHO5ktjqSUxz for ; + Sun, 5 Feb 2012 23:47:48 -0800 (PST) +Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com + [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 54A16431FAE for ; Sun, 5 Feb 2012 23:47:48 -0800 + (PST) +Received: by wgbdt12 with SMTP id dt12so5164430wgb.2 + for ; Sun, 05 Feb 2012 23:47:45 -0800 (PST) +Received: by 10.180.93.132 with SMTP id cu4mr11237232wib.9.1328514465744; + Sun, 05 Feb 2012 23:47:45 -0800 (PST) +Received: from hotblack-desiato.hh.sledj.net + (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) + by mx.google.com with ESMTPS id j16sm43906178wie.4.2012.02.05.23.47.43 + (version=TLSv1/SSLv3 cipher=OTHER); + Sun, 05 Feb 2012 23:47:44 -0800 (PST) +Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) + id A3D47A0484; Mon, 6 Feb 2012 07:47:41 +0000 (GMT) +To: Jameson Graef Rollins , + notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. +In-Reply-To: <87sjiobfu1.fsf@servo.finestructure.net> +References: <1327496913-4946-1-git-send-email-dme@dme.org> + <1327918561-16245-1-git-send-email-dme@dme.org> + <1327918561-16245-3-git-send-email-dme@dme.org> + <87sjiobfu1.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.11.1+152~g2c6710e (http://notmuchmail.org) + Emacs/24.0.92.1 (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Mon, 06 Feb 2012 07:47:38 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-Gm-Message-State: + ALoCoQnHMw1Y7jwVgH2JwT8qzJgxN80a/f61AgbBZXLfkK08uMzVQAzuwCdcVE0D5r8m2ca6cNR4 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 06 Feb 2012 07:47:49 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Sun, 05 Feb 2012 23:07:02 -0800, Jameson Graef Rollins wrote: +> Sorry to be so late on this, but I'm not a big fan of this new feature. +> I would prefer to always see the subject (or any other field for that +> matter) as is. + +The Emacs UI always replaced blank subjects with '[No Subject]' in +buffer names. The printing code also needed something other than a blank +subject for buffer renaming. + +> As a principle I would prefer there not be text replacements unless it's +> very clear that text has been replaced. Buttons work because it's clear +> they're buttons. This is not the case here, though, since this text +> replacement could actually be confused with real text. +>=20 +> It's also not clear to me why this feature would be needed. I have +> never found blank subjects confusing. The field is always clearly +> delineated, at least in search and show mode. If it's not clear +> elsewhere, maybe we can make the delineation of the subject field +> clearer, but leave the actual subject text string alone. +>=20 +> If some feel this feature is really needed we should at least have a +> customization variable. notmuch-unblank-subject? I don't have any good +> name suggestions, though. + +Updating `notmuch-prettify-subject' to use a user configurable string +(that can be set to the empty string) sounds like a good idea. Please +ensure that the various other bits of code that require something other +than a blank subject still work properly. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iEUEARECAAYFAk8vhZoACgkQaezQq/BJZRarMgCYrFque60z5T2myWwEd/Emj1Yh +5QCePKwlzHTZyk9mQ5KiwmdmDvxbprk= +=mPKI +-----END PGP SIGNATURE----- +--=-=-=--