From: Jani Nikula Date: Sat, 13 Oct 2012 22:09:47 +0000 (+0300) Subject: [PATCH v4 1/9] build: drop the -Wswitch-enum warning X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=a27446e59859a972f3f1be50df6ef1715ecc5b7b;p=notmuch-archives.git [PATCH v4 1/9] build: drop the -Wswitch-enum warning --- diff --git a/6e/06311d3d12454cd93e67206fe532b4409ea3fe b/6e/06311d3d12454cd93e67206fe532b4409ea3fe new file mode 100644 index 000000000..cfe0d06ea --- /dev/null +++ b/6e/06311d3d12454cd93e67206fe532b4409ea3fe @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C9318431FBD + for ; Sat, 13 Oct 2012 15:10:09 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id e9MrEBB93pDX for ; + Sat, 13 Oct 2012 15:10:08 -0700 (PDT) +Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com + [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 817B0431FBF + for ; Sat, 13 Oct 2012 15:10:04 -0700 (PDT) +Received: by mail-lb0-f181.google.com with SMTP id gg6so2988019lbb.26 + for ; Sat, 13 Oct 2012 15:10:03 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references + :in-reply-to:references:x-gm-message-state; + bh=CRsQEVmz+lCMFcMBqGVZJDcpLVTQehRR7S9aFYOPOok=; + b=caS0YwM1gTHoNUbXbL7QQIrY/kkPxKWrJI5Jf62WS+SSS3zf2gvzNSu3AuNJg+evHJ + ktzt4FkYmWsEXB3Gli3esq8KCXZqu/Xc1rIT9IDhj/R3oNIvksgXb2PmE6k7mGXZtdAk + Ts5Tt0idGXUjeCVqroFlxpbZoJkGgaVJTPtkXJ/VDKH7GsGMWVurrqfXMEIoZ4OQu3Vk + 4doSk3ny2nvxPKHJcD6q+JoURtVpYm64CI58Q5Ra5x53fY6SJY43ebGrHcrzh/f2R9Cv + 7h5Jl7yz3KTZF4oNLSK4VHnKAd0fYhy2rLx4VK5k9ijzWdwIq9pNPZpOEQkzAjAlOS5x + snug== +Received: by 10.152.48.102 with SMTP id k6mr6668952lan.12.1350166202985; + Sat, 13 Oct 2012 15:10:02 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id sx3sm3219055lab.9.2012.10.13.15.10.01 + (version=SSLv3 cipher=OTHER); Sat, 13 Oct 2012 15:10:02 -0700 (PDT) +From: Jani Nikula +To: notmuch@notmuchmail.org +Subject: [PATCH v4 1/9] build: drop the -Wswitch-enum warning +Date: Sun, 14 Oct 2012 01:09:47 +0300 +Message-Id: + <2945b4ebf110887bea5119df6db8088e1bbc5041.1350164594.git.jani@nikula.org> +X-Mailer: git-send-email 1.7.9.5 +In-Reply-To: +References: +In-Reply-To: +References: +X-Gm-Message-State: + ALoCoQmSwEiULnGsYTwdsFFMFWLoOuSJZ5hMuFju6/cxfxIYB9oF/FvUqTNblQNWHnGr4BKksbf0 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 13 Oct 2012 22:10:10 -0000 + +-Wswitch-enum is a bit awkward if a switch statement is intended to +handle just some of the named codes of an enumeration especially, and +leave the rest to the default label. + +We already have -Wall, which enables -Wswitch by default, and per GCC +documentation, "The only difference between -Wswitch and this option +[-Wswitch-enum] is that this option gives a warning about an omitted +enumeration code even if there is a default label." + +Drop -Wswitch-enum to not force listing all named codes of +enumerations in switch statements that have a default label. + +--- + +This will be useful in the next patch. +--- + configure | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/configure b/configure +index acb90a8..afa5c16 100755 +--- a/configure ++++ b/configure +@@ -532,7 +532,7 @@ fi + + WARN_CXXFLAGS="" + printf "Checking for available C++ compiler warning flags... " +-for flag in -Wall -Wextra -Wwrite-strings -Wswitch-enum; do ++for flag in -Wall -Wextra -Wwrite-strings; do + if ${CC} $flag -o minimal minimal.c > /dev/null 2>&1 + then + WARN_CXXFLAGS="${WARN_CXXFLAGS}${WARN_CXXFLAGS:+ }${flag}" +-- +1.7.9.5 +