From: Jameson Graef Rollins Date: Mon, 30 Jan 2012 17:47:34 +0000 (+1600) Subject: Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=a26cb3c26fde1303b0a1876f4e76e730d1836fda;p=notmuch-archives.git Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles --- diff --git a/a9/627bcdcc3608765665a5c5bdd752f4004e6667 b/a9/627bcdcc3608765665a5c5bdd752f4004e6667 new file mode 100644 index 000000000..182c9e497 --- /dev/null +++ b/a9/627bcdcc3608765665a5c5bdd752f4004e6667 @@ -0,0 +1,115 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E0439431E64 + for ; Mon, 30 Jan 2012 09:47:38 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id x8MTckHWPjAM for ; + Mon, 30 Jan 2012 09:47:38 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 6280B431FBC + for ; Mon, 30 Jan 2012 09:47:38 -0800 (PST) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id D3C6866E0166; + Mon, 30 Jan 2012 09:47:37 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com + [76.174.137.84]) (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 12F4C66E0162; + Mon, 30 Jan 2012 09:47:35 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id B2656885; Mon, 30 Jan 2012 09:47:34 -0800 (PST) +From: Jameson Graef Rollins +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles +In-Reply-To: <1327941064-20027-1-git-send-email-dme@dme.org> +References: <1327486729-18052-1-git-send-email-dme@dme.org> + <1327941064-20027-1-git-send-email-dme@dme.org> +User-Agent: Notmuch/0.11+128~g6f388fa (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 30 Jan 2012 09:47:34 -0800 +Message-ID: <87pqe1w095.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Jan 2012 17:47:39 -0000 + +--=-=-= +Content-Transfer-Encoding: quoted-printable + +On Mon, 30 Jan 2012 16:30:59 +0000, David Edmondson wrote: +> v3: +> - Add a toggle for line truncation (>). +> - Retain the state of a show buffer across a call to refresh (which +> includes the various toggles here). +>=20 +> David Edmondson (5): +> emacs: Rework crypto switch toggle. +> emacs: Allow `notmuch-show-mode' to display only matching messages. +> emacs: Allow the indentation of content to be toggled. +> emacs: Add a binding (>) to toggle the truncation of long lines. +> emacs: Retain the state of the buffer during +> `notmuch-show-refresh-view'. +>=20 +> emacs/notmuch-show.el | 183 +++++++++++++++++++++++++++++++++----------= +------ +> emacs/notmuch.el | 7 +- +> 2 files changed, 126 insertions(+), 64 deletions(-) + +Still testing, but so far works great. Again, this is=20 + +One thing I've noticed, which isn't actually part of this patch, is that +the long-line truncation doesn't respect the indentation, which makes +things look strange. + +But honestly I still don't like our method of displaying threads as a +giant chain of concatenated messages with indentation. But that's for +later work. + +Again, I haven't done a code review yet, but so far this seems to work +like a charm. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iQIcBAEBCAAGBQJPJte2AAoJEO00zqvie6q8UoQP/1hG8w1wiaCQbBHGEx9iK9F8 +k4MMBar/eWYzGnXdKy0dWCkeJY5GQk4wT+e5dLmHrgDtddJbT/ZZbdIFoRYM3U6h +AHtdSI0Nn6SW0RK5mItWOE1TSZUcH5qBOsWlGaYcsCUt1s/HFThcFNUoKz4Zgnwg +0jo+KO+BtDWO1MEVnIQUdC0u+OW+TsU0scA2Bkzhn41+6SJC4tBYs79p16dM4okQ +Zta5lbLLxeYXg2nHCu4s/LZbj4kPqltKFmKFbkA2IxtSk6ITg4TWAEOMQZygKd2s +lOftx2W2svx2VUm0zO2jecTqF/DlJwNpzzKpZ315iUG5kJ4k8vHCYcAaBVhzqriu +q56hlWrvlG9FVStn3AJdfLmSdOmXm7nvj+UvbfyPYAr485lOlJj6AbQ39F1zzIUv +zHIdp6wVKzVI+P4YX0PtiOZybMSPqbry+JlqjMdUnonJ79DG6U4LwuBARdI+tQgu +McqEdo996y+jjMtpSVYmsxxySFXbE3Gx+ZRC5KGJ5doHMsL7W5+4xvEwMt88gXyB +krsCqjdSDevqbMYB04pTUheoBoJ60ArV/Lk2uLhmihchNQdGTV9XXlvxWjfEoZrI +68vTumxNi3tbALGEB9/7jPGsMfMAfMOYEZZBeE6T6WPxKqKCXwxlK3AP0+/yqLFX +crTJdPpZjBrOq/n4234P +=65T9 +-----END PGP SIGNATURE----- +--=-=-=--