From: Austin Clements Date: Sat, 17 Mar 2012 15:50:23 +0000 (+2000) Subject: Re: [PATCH 3/5] cli: move search to the new --exclude= naming scheme. X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=a00e07f173499881c78e54410a2ceb2f48f28150;p=notmuch-archives.git Re: [PATCH 3/5] cli: move search to the new --exclude= naming scheme. --- diff --git a/b0/932d6e47c8576ed24032f94cd93c394d873c7e b/b0/932d6e47c8576ed24032f94cd93c394d873c7e new file mode 100644 index 000000000..cfec61811 --- /dev/null +++ b/b0/932d6e47c8576ed24032f94cd93c394d873c7e @@ -0,0 +1,112 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2D736431FAF + for ; Sat, 17 Mar 2012 08:50:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 27hqDDUAxzmx for ; + Sat, 17 Mar 2012 08:50:27 -0700 (PDT) +Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU + [18.9.25.15]) + by olra.theworths.org (Postfix) with ESMTP id 5D68C431FAE + for ; Sat, 17 Mar 2012 08:50:27 -0700 (PDT) +X-AuditID: 1209190f-b7f8a6d000000914-d4-4f64b2c17ae4 +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP + id 3E.EA.02324.1C2B46F4; Sat, 17 Mar 2012 11:50:25 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q2HFoPQj027685; + Sat, 17 Mar 2012 11:50:25 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2HFoNCF004098 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Sat, 17 Mar 2012 11:50:24 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1S8vtf-0003x5-5D; Sat, 17 Mar 2012 11:50:23 -0400 +Date: Sat, 17 Mar 2012 11:50:23 -0400 +From: Austin Clements +To: Mark Walters +Subject: Re: [PATCH 3/5] cli: move search to the new --exclude= naming scheme. +Message-ID: <20120317155023.GH2670@mit.edu> +References: <1331836925-31437-1-git-send-email-markwalters1009@gmail.com> + <1331836925-31437-4-git-send-email-markwalters1009@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1331836925-31437-4-git-send-email-markwalters1009@gmail.com> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFprAKsWRmVeSWpSXmKPExsUixG6nontwU4q/wcKdphar5/JYXL85k9mB + yWPnrLvsHs9W3WIOYIrisklJzcksSy3St0vgymj63sRccIu74vyCG+wNjBs5uxg5OSQETCSu + vXzCCmGLSVy4t56ti5GLQ0hgH6PEqqVnWCGcDYwSM08dZYRwTjJJbDnTCFW2hFFi0oTzTCD9 + LAKqEgefXgObxSagIbFt/3JGEFtEQEfi9qEF7CA2s4C0xLffzWD1wgJ+Em8+zgar4RXQlljz + 9gkTxNBORom3M1+xQiQEJU7OfMIC0awlcePfS6AiDrBBy/9xgIQ5BbwkVv/dBjZfVEBFYsrJ + bWwTGIVmIemehaR7FkL3AkbmVYyyKblVurmJmTnFqcm6xcmJeXmpRbomermZJXqpKaWbGEGB + zSnJv4Px20GlQ4wCHIxKPLwcE5L9hVgTy4orcw8xSnIwKYnytm5I8RfiS8pPqcxILM6ILyrN + SS0+xCjBwawkwiu1HCjHm5JYWZValA+TkuZgURLnVdN65yckkJ5YkpqdmlqQWgSTleHgUJLg + /b4RqFGwKDU9tSItM6cEIc3EwQkynAdo+FeQGt7igsTc4sx0iPwpRl2O7qmPLjEKseTl56VK + ifMmAFOKkABIUUZpHtwcWEJ6xSgO9JYw7yWQUTzAZAY36RXQEiagJTPLkkGWlCQipKQaGCuF + Ti5Kb9/P/9F0q/C15coPV0S4Lyot1bPfl28YJXzRJ+nFjflfefoFnPZfm7w5Q99gQblmcHqB + 7/zNU7letb2tYtnSwxr65Mn6fOlVJbwbtGRnOwsb7/xk+PTMzUWntLPytrfliG5uN1xo80fq + fMbvOcFytaZ5DzawfDq7VY871l84uMdJXomlOCPRUIu5qDgRAOFWCAcjAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 17 Mar 2012 15:50:28 -0000 + +Quoth Mark Walters on Mar 15 at 6:42 pm: +> This commit replaces the --no-exclude option with a +> --exclude=(true|false|flag) option. The default is to omit the +> excluded messages. +> +> The flag option only makes sense if output=summary (as otherwise there +> is nowhere to print the flag). In summary output exclude=false and +> exclude=flag give almost identical output: +> they differ in that with the exclude=flag option the match count +> (i.e., the x in [x/n] in the output) is the number of matching +> non-excluded messages rather than the number of matching messages. +> +> Note this changes the default for output=summary when no --exclude= +> option is given: it used to default to flag and now defaults to true +> (i.e. omit excluded messages). This is neccesary to keep the cli +> output uncluttered and for speed reasons. +> --- + +Code looks good, but I think there need to be a few more tests. In +particular, I think we need all 10 valid combinations of + +* --output=summary or --output=messages (those two are probably + enough) + +* The three types of exclude (or two for --output=messages) + +* Whether or not an excluded term is in the query + +Finally, the corpus should have three threads of interest: a thread +with no excluded messages, a thread with both excluded and +non-excluded messages, and a thread consisting entirely of excluded +messages. + +We already have many of these, but it would be good to systematically +cover the full gamut of possibilities.