From: Austin Clements Date: Sat, 14 Jul 2012 23:02:16 +0000 (+2000) Subject: [PATCH v3 4/8] emacs: Use result text properties for search result iteration X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=9c2aedb082d72ffa41db720892fe8a7d75bff8ec;p=notmuch-archives.git [PATCH v3 4/8] emacs: Use result text properties for search result iteration --- diff --git a/31/04e8acf44c79a9e0ae45c842e3b9ea2549c345 b/31/04e8acf44c79a9e0ae45c842e3b9ea2549c345 new file mode 100644 index 000000000..3bde477f0 --- /dev/null +++ b/31/04e8acf44c79a9e0ae45c842e3b9ea2549c345 @@ -0,0 +1,199 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A02C1429E3F + for ; Sat, 14 Jul 2012 16:02:29 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id K0jOF6+FBmJ5 for ; + Sat, 14 Jul 2012 16:02:28 -0700 (PDT) +Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU + [18.7.68.37]) + by olra.theworths.org (Postfix) with ESMTP id CA017431E84 + for ; Sat, 14 Jul 2012 16:02:26 -0700 (PDT) +X-AuditID: 12074425-b7f9b6d0000008c4-b5-5001fa82ea7e +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP + id AC.00.02244.28AF1005; Sat, 14 Jul 2012 19:02:26 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q6EN2Pti010943; + Sat, 14 Jul 2012 19:02:25 -0400 +Received: from drake.dyndns.org + (209-6-116-242.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com + [209.6.116.242]) (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6EN2O0a008496 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Sat, 14 Jul 2012 19:02:24 -0400 (EDT) +Received: from amthrax by drake.dyndns.org with local (Exim 4.77) + (envelope-from ) + id 1SqBLz-0002GA-Tc; Sat, 14 Jul 2012 19:02:23 -0400 +From: Austin Clements +To: notmuch@notmuchmail.org +Subject: [PATCH v3 4/8] emacs: Use result text properties for search result + iteration +Date: Sat, 14 Jul 2012 19:02:16 -0400 +Message-Id: <1342306940-7499-5-git-send-email-amdragon@mit.edu> +X-Mailer: git-send-email 1.7.10 +In-Reply-To: <1342306940-7499-1-git-send-email-amdragon@mit.edu> +References: <1342140319-19859-1-git-send-email-amdragon@mit.edu> + <1342306940-7499-1-git-send-email-amdragon@mit.edu> +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFjrKIsWRmVeSWpSXmKPExsUixG6nrtv0izHAYMU5KYs9+7wsVs/lsbh+ + cyazA7PH3dNcHjtn3WX3eLbqFnMAcxSXTUpqTmZZapG+XQJXxt/m/0wFMzQq5pw8w9rAuE2h + i5GTQ0LARKJ9eg8ThC0mceHeerYuRi4OIYF9jBL9F95CORsYJTa272SHcB4xSfS3bIDKzGWU + OLFnBQtIP5uAhsS2/csZQWwRAWmJnXdns4LYzAJpEt/b34LFhQVCJfY/uAG2j0VAVeLC7W9s + IDavgL3Ek3MX2SHukJd4er8PLM4p4CBx+MIJsDlCAmUSN558Z53AyL+AkWEVo2xKbpVubmJm + TnFqsm5xcmJeXmqRroVebmaJXmpK6SZGcGi5qO5gnHBI6RCjAAejEg9voj9DgBBrYllxZe4h + RkkOJiVR3s1fGQOE+JLyUyozEosz4otKc1KLDzFKcDArifBKgOR4UxIrq1KL8mFS0hwsSuK8 + N1Ju+gsJpCeWpGanphakFsFkZTg4lCR4C38CNQoWpaanVqRl5pQgpJk4OEGG8wAN7wap4S0u + SMwtzkyHyJ9iVJQS5+0FSQiAJDJK8+B6YbH/ilEc6BVh3qUgVTzAtAHX/QpoMBPQ4Fk///kD + DS5JREhJNTBuZO9hMfzv3bEt4/rbibf9b8i8368YlbfhDk/dHAnnuNVfdRbt42uxVZiRavDm + /a94tdmy50o7XSLf7ta6LOA+/8wWlmNHv94yWS14hkljel+KWobeSj2h+MNW076+Mi2qL1wX + b7to+ekrx0q1/paGMeQcOfqowksuLWT52fzuhPRpUz8ff2GoxFKckWioxVxUnAgAedu6V9gC AAA= +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 14 Jul 2012 23:02:29 -0000 + +This simplifies the traversal of regions of results and eliminates the +need for save-excursions (which tend to get in the way of maintaining +point when we make changes to the buffer). It also fixes some strange +corner cases in the old line-based code where results that bordered +the region but were not included in it could be affected by region +commands. Coincidentally, this also essentially enables multi-line +search result formats; the only remaining non-multi-line-capable +functions are notmuch-search-{next,previous}-thread, which are only +used for interactive navigation. +--- + emacs/notmuch.el | 78 ++++++++++++++++++++++++++++++++++-------------------- + 1 file changed, 50 insertions(+), 28 deletions(-) + +diff --git a/emacs/notmuch.el b/emacs/notmuch.el +index 8e1a769..49367e0 100644 +--- a/emacs/notmuch.el ++++ b/emacs/notmuch.el +@@ -69,7 +69,13 @@ + date, count, authors, subject, tags + For example: + (setq notmuch-search-result-format \(\(\"authors\" . \"%-40s\"\) +- \(\"subject\" . \"%s\"\)\)\)" ++ \(\"subject\" . \"%s\"\)\)\) ++Line breaks are permitted in format strings. Note that a line ++break at the end of an \"authors\" field will get elided if the ++authors list is long; place it instead at the beginning of the ++following field. To enter a line break when setting this ++variable with setq, use \\n. To enter a line break in customize, ++press \\[quoted-insert] C-j." + :type '(alist :key-type (string) :value-type (string)) + :group 'notmuch-search) + +@@ -427,17 +433,40 @@ returns nil" + (next-single-property-change (or pos (point)) 'notmuch-search-result + nil (point-max)))) + ++(defun notmuch-search-foreach-result (beg end function) ++ "Invoke FUNCTION for each result between BEG and END. ++ ++FUNCTION should take one argument. It will be applied to the ++character position of the beginning of each result that overlaps ++the region between points BEG and END. As a special case, if (= ++BEG END), FUNCTION will be applied to the result containing point ++BEG." ++ ++ (lexical-let ((pos (notmuch-search-result-beginning beg)) ++ ;; End must be a marker in case function changes the ++ ;; text. ++ (end (copy-marker end)) ++ ;; Make sure we examine at least one result, even if ++ ;; (= beg end). ++ (first t)) ++ ;; We have to be careful if the region extends beyond the results. ++ ;; In this case, pos could be null or there could be no result at ++ ;; pos. ++ (while (and pos (or (< pos end) first)) ++ (when (notmuch-search-get-result pos) ++ (funcall function pos)) ++ (setq pos (notmuch-search-result-end pos) ++ first nil)))) ++;; Unindent the function argument of notmuch-search-foreach-result so ++;; the indentation of callers doesn't get out of hand. ++(put 'notmuch-search-foreach-result 'lisp-indent-function 2) ++ + (defun notmuch-search-properties-in-region (property beg end) +- (save-excursion +- (let ((output nil) +- (last-line (line-number-at-pos end)) +- (max-line (- (line-number-at-pos (point-max)) 2))) +- (goto-char beg) +- (beginning-of-line) +- (while (<= (line-number-at-pos) (min last-line max-line)) +- (setq output (cons (get-text-property (point) property) output)) +- (forward-line 1)) +- output))) ++ (let (output) ++ (notmuch-search-foreach-result beg end ++ (lambda (pos) ++ (push (get-text-property pos property) output))) ++ output)) + + (defun notmuch-search-find-thread-id () + "Return the thread for the current thread" +@@ -517,28 +546,21 @@ and will also appear in a buffer named \"*Notmuch errors*\"." + (plist-get (notmuch-search-get-result pos) :tags)) + + (defun notmuch-search-get-tags-region (beg end) +- (save-excursion +- (let ((output nil) +- (last-line (line-number-at-pos end)) +- (max-line (- (line-number-at-pos (point-max)) 2))) +- (goto-char beg) +- (while (<= (line-number-at-pos) (min last-line max-line)) +- (setq output (append output (notmuch-search-get-tags))) +- (forward-line 1)) +- output))) ++ (let (output) ++ (notmuch-search-foreach-result beg end ++ (lambda (pos) ++ (setq output (append output (notmuch-search-get-tags pos))))) ++ output)) + + (defun notmuch-search-tag-region (beg end &optional tag-changes) + "Change tags for threads in the given region." + (let ((search-string (notmuch-search-find-thread-id-region-search beg end))) + (setq tag-changes (funcall 'notmuch-tag search-string tag-changes)) +- (save-excursion +- (let ((last-line (line-number-at-pos end)) +- (max-line (- (line-number-at-pos (point-max)) 2))) +- (goto-char beg) +- (while (<= (line-number-at-pos) (min last-line max-line)) +- (notmuch-search-set-tags +- (notmuch-update-tags (notmuch-search-get-tags) tag-changes)) +- (forward-line)))))) ++ (notmuch-search-foreach-result beg end ++ (lambda (pos) ++ (notmuch-search-set-tags ++ (notmuch-update-tags (notmuch-search-get-tags pos) tag-changes) ++ pos))))) + + (defun notmuch-search-tag (&optional tag-changes) + "Change tags for the currently selected thread or region. +-- +1.7.10 +