From: Peter Wang Date: Sat, 14 Apr 2012 01:41:01 +0000 (+1000) Subject: [PATCH v4 1/6] config: Fix free in 'config get' implementation. X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=9ba229533a1940f8f75114ae9b36acd8f92154e1;p=notmuch-archives.git [PATCH v4 1/6] config: Fix free in 'config get' implementation. --- diff --git a/fb/34116e9fa1410436b2b46347ab8630185fbd24 b/fb/34116e9fa1410436b2b46347ab8630185fbd24 new file mode 100644 index 000000000..8ac055369 --- /dev/null +++ b/fb/34116e9fa1410436b2b46347ab8630185fbd24 @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BA38E431FBD + for ; Fri, 13 Apr 2012 18:42:00 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OxXs9kGvkL8I for ; + Fri, 13 Apr 2012 18:42:00 -0700 (PDT) +Received: from mail-pz0-f45.google.com (mail-pz0-f45.google.com + [209.85.210.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 19589431FB6 + for ; Fri, 13 Apr 2012 18:42:00 -0700 (PDT) +Received: by mail-pz0-f45.google.com with SMTP id x6so4543752dac.18 + for ; Fri, 13 Apr 2012 18:41:59 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; + bh=mkSjrE63V0UO6LxveJEQlNNV/Rp+LMoxf9IM3FkxXPs=; + b=FzpfA47ugLXgjj2IPsPlkmMfM9hUkvrkRXTLQRW0ypEjfhR9BC6gQtgJNLs9HJdGi7 + +/2OAbTrQwsM6Gn1bVtEtaF3oaBhHiW0hQNHTwS9YL4sIcC6LrlTlKrGJ0di3en9VQOl + 8TWFF6VBeMILAlnR7Qh9w6RBRMU5AhpyXvEvIwKonkqa8DAr25iaKmTylicQ0jVMcHfY + l9W7o6TWxsTGaq4X+SnAoR2aH/01qJq8TYrhEBdmiac/kATymxHKMaMrOj23yi1GRCtd + Y3jIMz8deaCJ+u19Nxu/0y9RNXbQc4CqywJ4cJvXHOZe3F4U2h9wqmjbOhQ3bxSYlTO9 + M4oQ== +Received: by 10.68.202.167 with SMTP id kj7mr9222501pbc.9.1334367719823; + Fri, 13 Apr 2012 18:41:59 -0700 (PDT) +Received: from localhost (215.42.233.220.static.exetel.com.au. + [220.233.42.215]) + by mx.google.com with ESMTPS id h10sm10245042pbh.69.2012.04.13.18.41.54 + (version=TLSv1/SSLv3 cipher=OTHER); + Fri, 13 Apr 2012 18:41:58 -0700 (PDT) +From: Peter Wang +To: notmuch@notmuchmail.org +Subject: [PATCH v4 1/6] config: Fix free in 'config get' implementation. +Date: Sat, 14 Apr 2012 11:41:01 +1000 +Message-Id: <1334367666-10954-2-git-send-email-novalazy@gmail.com> +X-Mailer: git-send-email 1.7.4.4 +In-Reply-To: <1334367666-10954-1-git-send-email-novalazy@gmail.com> +References: <1332282698-7951-1-git-send-email-novalazy@gmail.com> + <1334367666-10954-1-git-send-email-novalazy@gmail.com> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 14 Apr 2012 01:42:00 -0000 + +The array returned by g_key_file_get_string_list() should be freed with +g_strfreev(), not free(). +--- + notmuch-config.c | 2 +- + 1 files changed, 1 insertions(+), 1 deletions(-) + +diff --git a/notmuch-config.c b/notmuch-config.c +index e9b2750..85fc774 100644 +--- a/notmuch-config.c ++++ b/notmuch-config.c +@@ -751,7 +751,7 @@ notmuch_config_command_get (void *ctx, char *item) + for (i = 0; i < length; i++) + printf ("%s\n", value[i]); + +- free (value); ++ g_strfreev (value); + } + + notmuch_config_close (config); +-- +1.7.4.4 +