From: Mark Walters Date: Wed, 11 Jul 2012 06:55:31 +0000 (+0100) Subject: Re: [PATCH v3 0/9] JSON-based search-mode X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=9a0ba7ad3ea10281d585c73ddf4a6fc71a339fd7;p=notmuch-archives.git Re: [PATCH v3 0/9] JSON-based search-mode --- diff --git a/30/8b92b9eb05575a226b3751367913e6088425c8 b/30/8b92b9eb05575a226b3751367913e6088425c8 new file mode 100644 index 000000000..e04e0670e --- /dev/null +++ b/30/8b92b9eb05575a226b3751367913e6088425c8 @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 692B8431FC7 + for ; Tue, 10 Jul 2012 23:55:39 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OOZNpp10o3Xz for ; + Tue, 10 Jul 2012 23:55:39 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E7E95431FAE + for ; Tue, 10 Jul 2012 23:55:38 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Soqph-0004VG-T2; Wed, 11 Jul 2012 07:55:34 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1Soqph-00053X-Ko; Wed, 11 Jul 2012 07:55:33 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH v3 0/9] JSON-based search-mode +In-Reply-To: <1341870162-17782-1-git-send-email-amdragon@mit.edu> +References: <1341354059-29396-1-git-send-email-amdragon@mit.edu> + <1341870162-17782-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.13.2+61~gf708609 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 11 Jul 2012 07:55:31 +0100 +Message-ID: <87txxeeqho.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 005384e31a3942f080e334573aa7a06e (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 11 Jul 2012 06:55:39 -0000 + +On Mon, 09 Jul 2012, Austin Clements wrote: +> This fixes the docstings for notmuch-json-read and notmuch-json-eof as +> suggested by Mark. No other changes. + +This is a definite +1 from me: + +It all seems to work perfectly, and fixes a definite bug (and makes it +easy to fix some other bugs when changing tags in search results etc) + +Moreover I modified notmuch-pick to use the incremental parser and it +also works fine. Pick parses the output from notmuch-show so this +provides good evidence that the parser can parse both of the cli json +outputs properly (I believe it will parse any JSON but the fact that it +parses both outputs that we use is a good sign). + +Best wishes + +Mark + +