From: Sebastien Binet Date: Wed, 18 Jul 2012 20:36:48 +0000 (+0200) Subject: Re: [PATCH 1/7] go: Use iota in enum bindings X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=98d13a25174780736fc10b4cc2a443152de5487c;p=notmuch-archives.git Re: [PATCH 1/7] go: Use iota in enum bindings --- diff --git a/e7/37d96a31c886af6fe50b4efb0c3608da946890 b/e7/37d96a31c886af6fe50b4efb0c3608da946890 new file mode 100644 index 000000000..b9ce7c0d8 --- /dev/null +++ b/e7/37d96a31c886af6fe50b4efb0c3608da946890 @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5A951431FAF + for ; Wed, 18 Jul 2012 13:37:37 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -5 +X-Spam-Level: +X-Spam-Status: No, score=-5 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_HI=-5] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 2FkNYtjj+dHJ for ; + Wed, 18 Jul 2012 13:37:36 -0700 (PDT) +Received: from CERNMX32.cern.ch (cernmx32.cern.ch [137.138.144.178]) + (using TLSv1 with cipher AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 88362431FAE + for ; Wed, 18 Jul 2012 13:37:36 -0700 (PDT) +Received: from CERNFE22.cern.ch (137.138.144.151) by cernmxgwlb2.cern.ch + (137.138.144.178) with Microsoft SMTP Server (TLS) id 14.2.283.3; + Wed, 18 Jul 2012 22:37:34 +0200 +Received: from localhost (134.158.88.68) by smtp.cern.ch (137.138.144.172) + with Microsoft SMTP Server (TLS) id 14.2.298.4; + Wed, 18 Jul 2012 22:37:34 +0200 +From: Sebastien Binet +To: Austin Clements , Adrien Bustany +Subject: Re: [PATCH 1/7] go: Use iota in enum bindings +In-Reply-To: <20120718201748.GS31670@mit.edu> +References: <1342636475-16057-1-git-send-email-adrien@bustany.org> + <1342636475-16057-2-git-send-email-adrien@bustany.org> + <20120718201748.GS31670@mit.edu> +User-Agent: Notmuch/0.13.2+77~g39beeb2 (http://notmuchmail.org) Emacs/24.1.1 + (x86_64-unknown-linux-gnu) +Date: Wed, 18 Jul 2012 22:36:48 +0200 +Message-ID: <87fw8ox0v3.fsf@cern.ch> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; + protocol="application/pgp-signature" +X-Originating-IP: [134.158.88.68] +Keywords: CERN SpamKiller Note: -50 +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 18 Jul 2012 20:37:37 -0000 + +--=-=-= +Content-Type: text/plain + +Austin Clements writes: + +> Hah. I guess nobody has tried to modify a notmuch database using the +> Go bindings. +> +> Could this instead assign the constants to +> C.NOTMUCH_DATABASE_MODE_READ_ONLY, etc, rather than duplicating their +> values? It would be nice to do that for the Status values as well +> (which are correctly using iota, at least). + +yep. +I have a few fixes like that in my repo: +https://github.com/sbinet/notmuch/commits/dev/go-bindings/bindings/go/src/notmuch + +https://github.com/sbinet/notmuch/commit/38713de1b90a29b66b2a7f310065a3ffcf527d9b#L1L88 + +-s + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2.0.19 (GNU/Linux) + +iEYEARECAAYFAlAHHoEACgkQPj4AVbsZCCZRIwCfby8nRaaS5KH5dps8JkOqtFLZ +xvEAnjFDHq1SD1dGQDWt4pAp94iSblmB +=QfDt +-----END PGP SIGNATURE----- +--=-=-=--