From: Mark Walters Date: Sun, 1 Apr 2012 10:26:07 +0000 (+0100) Subject: Re: [BUG/PATCH v3 0/4] Bug fixes for reply: three bugs, one series X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=97593c2639dd36757bb58005ab77ac62cedb4ac9;p=notmuch-archives.git Re: [BUG/PATCH v3 0/4] Bug fixes for reply: three bugs, one series --- diff --git a/c5/221b90e595f9295d89ef88d82fd356270acc3d b/c5/221b90e595f9295d89ef88d82fd356270acc3d new file mode 100644 index 000000000..f1b6e7fe8 --- /dev/null +++ b/c5/221b90e595f9295d89ef88d82fd356270acc3d @@ -0,0 +1,122 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E9C18431E82 + for ; Sun, 1 Apr 2012 03:26:05 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id wBp7pDFOHhXE for ; + Sun, 1 Apr 2012 03:26:05 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 050C8431FAF + for ; Sun, 1 Apr 2012 03:26:04 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SEHyw-0004rN-Qc; Sun, 01 Apr 2012 11:26:01 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SEHyw-0004hS-IO; Sun, 01 Apr 2012 11:25:58 +0100 +From: Mark Walters +To: Adam Wolfe Gordon , notmuch@notmuchmail.org +Subject: Re: [BUG/PATCH v3 0/4] Bug fixes for reply: three bugs, one series +In-Reply-To: <1333240404-13076-1-git-send-email-awg+notmuch@xvx.ca> +References: <1333240404-13076-1-git-send-email-awg+notmuch@xvx.ca> +User-Agent: Notmuch/0.12+88~g77b5664 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 01 Apr 2012 11:26:07 +0100 +Message-ID: <87bonbagu8.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 2bfded18bcbad67a7195c0f6f29558e3 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 01 Apr 2012 10:26:06 -0000 + + +On Sun, 01 Apr 2012, Adam Wolfe Gordon wrote: +> Hi everyone, +> +> This series is a combination of the three bugfixes I sent this week [1] +> [2]. As Mark pointed out, the fix for the emacs 23.2 bug actually fixes the +> alternate address bug as well, so there's no real reason to have a +> separate patch for it, especially one that implements a different fix. +> +> I've also adjusted the reply tests so that they show all the headers in the +> reply message. This would catch the References/User-Agent bug. +> +> I'm hoping these can be pushed quickly, as they do fix bugs, and the +> individual patches were reviewed and pretty much ready to go. +> +> [1] id:"1333038410-17927-1-git-send-email-awg+notmuch@xvx.ca" +> [2] id:"1332941635-21019-1-git-send-email-awg+notmuch@xvx.ca" + +I have tested this on emacs 23.2 and emacs 23.3 and it seems to work on +both. As mentioned on irc there is a minor conflict with Austin's commit +ee118001 (quote message ids) in the lib part of patch 2/4 but it's only +in the first line of the context. + +My lisp is not good enough to review the actual patches. + +Best wishes + +Mark + +> Adam Wolfe Gordon (4): +> test: Tests for reply from alternate addresses in emacs +> emacs: Fix two bugs in reply +> test: Show all headers in emacs reply tests +> emacs: Fix the References header in reply +> +> emacs/notmuch-lib.el | 7 +++- +> emacs/notmuch-mua.el | 36 +++++++++++++++++---- +> test/emacs | 84 +++++++++++++++++++++++++++++++++++++++++++++----- +> 3 files changed, 110 insertions(+), 17 deletions(-) +> +> -- +> 1.7.5.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch