From: Mark Walters Date: Sun, 15 Apr 2012 17:25:05 +0000 (+0100) Subject: Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=970520d9cb374fc9bf66ba29afa43fc0bac05100;p=notmuch-archives.git Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name. --- diff --git a/a0/c4750ab0155eb182132dabf09186e154523c2a b/a0/c4750ab0155eb182132dabf09186e154523c2a new file mode 100644 index 000000000..94e8fb44e --- /dev/null +++ b/a0/c4750ab0155eb182132dabf09186e154523c2a @@ -0,0 +1,128 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 72E2A431FAF + for ; Sun, 15 Apr 2012 10:24:49 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yyg1xyuekjZ8 for ; + Sun, 15 Apr 2012 10:24:48 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A7960431FAE + for ; Sun, 15 Apr 2012 10:24:48 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SJTBu-0006sr-Ie; Sun, 15 Apr 2012 18:24:46 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SJTBu-0002yE-A3; Sun, 15 Apr 2012 18:24:46 +0100 +From: Mark Walters +To: Jameson Graef Rollins , + Notmuch Mail +Subject: Re: [PATCH 1/3] emacs: modify help message for + notmuch-search-line-faces to reflect preferred "deleted" tag name. +In-Reply-To: <1326826969-23545-1-git-send-email-jrollins@finestructure.net> +References: <87vcoaywyu.fsf@servo.finestructure.net> + <1326826969-23545-1-git-send-email-jrollins@finestructure.net> +User-Agent: Notmuch/0.12+110~gbc97b4a (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 15 Apr 2012 18:25:05 +0100 +Message-ID: <87iph06h72.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: be5355f3ddbe189c75273f9b8033090c (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 15 Apr 2012 17:24:49 -0000 + +On Tue, 17 Jan 2012, Jameson Graef Rollins wrote: +> No functional change here. The help message previously referred to +> the "delete" tag, but "deleted" is now preferred, so hopefully this +> will reduce any potential confusion. + +This patch is trivially correct regardless of the rest of the +series. + +I think the rest of the series (which provides keybindings for +adding/removing the delete tag to messages/threads) is worthwhile +particularly now the exclude stuff is fairly complete (feedback at the +time looked positive). + +Patch 2/3 needs simple but genuine rebasing as the names of the +tagging functions have changed though. + +Best wishes + +Mark + +> --- +> emacs/notmuch.el | 4 ++-- +> 1 files changed, 2 insertions(+), 2 deletions(-) +> +> diff --git a/emacs/notmuch.el b/emacs/notmuch.el +> index e4bca51..67ecd3a 100644 +> --- a/emacs/notmuch.el +> +++ b/emacs/notmuch.el +> @@ -660,12 +660,12 @@ This function advances the next thread when finished." +> Here is an example of how to color search results based on tags. +> (the following text would be placed in your ~/.emacs file): +> +> - (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\" +> + (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\" +> :background \"blue\")) +> (\"unread\" . (:foreground \"green\")))) +> +> The attributes defined for matching tags are merged, with later +> -attributes overriding earlier. A message having both \"delete\" +> +attributes overriding earlier. A message having both \"deleted\" +> and \"unread\" tags with the above settings would have a green +> foreground and blue background." +> :type '(alist :key-type (string) :value-type (custom-face-edit)) +> -- +> 1.7.7.3 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch