From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Sat, 5 May 2012 11:15:35 +0000 (+0200) Subject: Re: [PATCH 1/5] go: reorganize the go bindings X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=965142f05c371989079f5a3d12ca7a9aa0b5fd0e;p=notmuch-archives.git Re: [PATCH 1/5] go: reorganize the go bindings --- diff --git a/7b/0d75b2a535e68d9e4ba0df6820aece81c5cd8f b/7b/0d75b2a535e68d9e4ba0df6820aece81c5cd8f new file mode 100644 index 000000000..ee835b305 --- /dev/null +++ b/7b/0d75b2a535e68d9e4ba0df6820aece81c5cd8f @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8D561431FB6 + for ; Sat, 5 May 2012 04:16:50 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XM8BEVLGEvfZ for ; + Sat, 5 May 2012 04:16:49 -0700 (PDT) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id BBFC1431FAE + for ; Sat, 5 May 2012 04:16:49 -0700 (PDT) +Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id 33CA6588B05 + for ; Sat, 5 May 2012 13:16:45 +0200 (CEST) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id 92921DF2A3; Sat, 5 May 2012 13:16:44 +0200 (CEST) +Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de + [10.1.1.155]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client + certificate requested) (Authenticated sender: teythoon) by + mail.jade-hamburg.de (Postfix) with ESMTPSA id 6E39CDF2A0; Sat, 5 May 2012 + 13:16:39 +0200 (CEST) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77) + (envelope-from ) + id 1SQcxb-0008Cg-Gx; Sat, 05 May 2012 13:15:35 +0200 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: quoted-printable +To: Austin Clements , +From: Justus Winter <4winter@informatik.uni-hamburg.de> +In-Reply-To: <20120504184320.GO2704@mit.edu> +References: <20120430195420.2528.48612@thinkbox.jade-hamburg.de> + <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de> + <20120504183822.GN2704@mit.edu> <20120504184320.GO2704@mit.edu> +Message-ID: <20120505111535.3687.9018@thinkbox.jade-hamburg.de> +User-Agent: alot/0.3+ +Subject: Re: [PATCH 1/5] go: reorganize the go bindings +Date: Sat, 05 May 2012 13:15:35 +0200 +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 05 May 2012 11:16:50 -0000 + +Quoting Austin Clements (2012-05-04 20:43:20) +> Quoth myself on May 04 at 2:38 pm: +> > Quoth Justus Winter on Apr 30 at 9:55 pm: +> > > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de> +> > = + +> > Whole series LGTM (and yay gofmt!). I have only two minor comments. +> > = + +> > It would be nice to have a little more log message for some of these. +> > Mostly the first one could use some explanation of why you're +> > rearranging the source tree and a mention that there are no changes to +> > the files (since this is hard to get from the diff). + +Good point. + +> > It would also be nice if this could optionally be built using the +> > libnotmuch and notmuch.h directly from the source tree containing the +> > Go bindings, rather than requiring them to be installed system-wide. +> > I don't know Go 1's build system well enough to know if there's an +> > easy way to do this. + +Yes, I've been pondering that myself. There are CGO_CFLAGS and +CGO_LDFLAGS that could be used to point the c compiler to the right +paths. I'll experiment with this and propose a patch. + +> Oh, also a news patch would be good, though that can obviously be +> separate. + +Sure. + +I'll send an updated patch series. Thanks for the review. + +Justus