From: Tomi Ollila Date: Wed, 21 Nov 2012 08:25:36 +0000 (+0200) Subject: Re: [PATCH] test: Produce useful output when the HTML with images test fails X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=94f0dde1dd52a2087e12d056ee0474568fad97d1;p=notmuch-archives.git Re: [PATCH] test: Produce useful output when the HTML with images test fails --- diff --git a/d4/9d15d65c95bdf848aa7401900c4941aad7229b b/d4/9d15d65c95bdf848aa7401900c4941aad7229b new file mode 100644 index 000000000..52d992df2 --- /dev/null +++ b/d4/9d15d65c95bdf848aa7401900c4941aad7229b @@ -0,0 +1,126 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 79B2B431FB6 + for ; Wed, 21 Nov 2012 00:25:39 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id T-IG+qriIA1O for ; + Wed, 21 Nov 2012 00:25:38 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id E0C62431FAF + for ; Wed, 21 Nov 2012 00:25:37 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id BF32210010B; + Wed, 21 Nov 2012 10:25:36 +0200 (EET) +From: Tomi Ollila +To: Austin Clements , Tom Prince +Subject: Re: [PATCH] test: Produce useful output when the HTML with images + test fails +In-Reply-To: +References: <1353427125-13854-1-git-send-email-amdragon@mit.edu> + +User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 21 Nov 2012 08:25:39 -0000 + +On Wed, Nov 21 2012, Tomi Ollila wrote: + +> On Tue, Nov 20 2012, Austin Clements wrote: +> +>> Previously, this would simply indicate that the grep failed without +>> any indication of the Emacs output it failed on. Now we take +>> advantage of the test framework's handling of stdout to display the +>> incorrect Emacs output if the test fails. +>> --- +>> +>> Besides being a good idea in general, this is the first step toward +>> fixing this test on the Notmuch buildbot, since right now there's no +>> indication of why it's failing. +> +> Tom: could you do separate test on the buildbot machine (master-emacs24 +> config) with this patch applied and then running +> NOTMUCH_TESTS=emacs make test + +Hmm, I just remembered something: + +>From notmuch IRC log Thu Oct 25 2012 + +--8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<-- +< Domo_> For me the 'shr test fails by missing libxml-parse-html-region ... +< Domo_> which is defined in src/xml.c -- and exists by default on + another emacs... +< Domo_> which probably means that my self-compiled emacs24 just doesn't + have that xml code compiled in :( +< Domo_> #ifdef HAVE_LIBXML2 +< Domo_> ... +< Domo_> #endif /* HAVE_LIBXML2 */ +--8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<-- + +So, this is something to be checked for -- installing +libxml2-devel-2.7.6-8.el6_3.3.x86_64 (on Scientific Linux 6 machine) +and rebuilding emacs made things work for me. + +I'd guess the recipe to build emacs 24 on gentoo had this dependency +but maybe emacs24 is so new that at the time buildbot machine got +emacs24 that wasn't there yet ??? + +Tomi + +> +> Tomi +> +>> test/emacs | 5 +++-- +>> 1 file changed, 3 insertions(+), 2 deletions(-) +>> +>> diff --git a/test/emacs b/test/emacs +>> index 77265b0..5649d55 100755 +>> --- a/test/emacs +>> +++ b/test/emacs +>> @@ -809,9 +809,10 @@ test_emacs "(let ((mm-text-html-renderer +>> (notmuch-show \"id:${gen_msg_id}\")) +>> (test-output)" > /dev/null +>> # Different Emacs versions and renderers give very different results, +>> -# so just check that something reasonable showed up. +>> +# so just check that something reasonable showed up. We first cat the +>> +# output so the test framework will print it if the test fails. +>> test_expect_success "Rendering HTML mail with images" \ +>> - 'grep -q smiley OUTPUT' +>> + 'cat OUTPUT && grep -q smiley OUTPUT' +>> +>> +>> test_done +>> -- +>> 1.7.10.4 +>> +>> _______________________________________________ +>> notmuch mailing list +>> notmuch@notmuchmail.org +>> http://notmuchmail.org/mailman/listinfo/notmuch