From: Adam Wolfe Gordon Date: Wed, 15 Feb 2012 15:20:31 +0000 (+1700) Subject: Re: [PATCH 0/8] Rewrite JSON show format X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=93d5bd6335348cbf9ac954cbb87d0fe23839610a;p=notmuch-archives.git Re: [PATCH 0/8] Rewrite JSON show format --- diff --git a/5e/ffb23dbe9f1c5dc38d594d0b19df1b8cfeb059 b/5e/ffb23dbe9f1c5dc38d594d0b19df1b8cfeb059 new file mode 100644 index 000000000..6b84f90f3 --- /dev/null +++ b/5e/ffb23dbe9f1c5dc38d594d0b19df1b8cfeb059 @@ -0,0 +1,78 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 88F47429E30 + for ; Wed, 15 Feb 2012 07:20:39 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id D0aCccaSWMVf for ; + Wed, 15 Feb 2012 07:20:35 -0800 (PST) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 09A32429E26 + for ; Wed, 15 Feb 2012 07:20:34 -0800 (PST) +Received: by lahd3 with SMTP id d3so1161781lah.26 + for ; Wed, 15 Feb 2012 07:20:32 -0800 (PST) +MIME-Version: 1.0 +Received: by 10.152.128.230 with SMTP id nr6mr15798260lab.27.1329319231965; + Wed, 15 Feb 2012 07:20:31 -0800 (PST) +Sender: awg@xvx.ca +Received: by 10.112.90.20 with HTTP; Wed, 15 Feb 2012 07:20:31 -0800 (PST) +X-Originating-IP: [96.52.216.56] +In-Reply-To: +References: <1329240823-7856-1-git-send-email-amdragon@mit.edu> + +Date: Wed, 15 Feb 2012 08:20:31 -0700 +X-Google-Sender-Auth: ILx-RWHKfzUjOtNR4DXFrVpjM50 +Message-ID: + +Subject: Re: [PATCH 0/8] Rewrite JSON show format +From: Adam Wolfe Gordon +To: Tomi Ollila +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-Gm-Message-State: + ALoCoQn4MJ9V7VGUgtNCxGmdOlKDQQFxOloV5msIzShaSLZXofmVs3L4ZU0FMiA6oQ84F1/BfKEX +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 15 Feb 2012 15:20:39 -0000 + +On Wed, Feb 15, 2012 at 08:00, Tomi Ollila wrote: +> Most json-related tests pass (for me), but I get this: +> +> =A0FAIL =A0 notmuch-show for message with invalid From +> =A0 =A0 =A0 =A0--- emacs.10.expected =A0 2012-02-15 14:28:48.000000000 +0= +000 +> =A0 =A0 =A0 =A0+++ emacs.10.output =A0 =A0 2012-02-15 14:28:48.000000000 = ++0000 +> =A0 =A0 =A0 =A0@@ -1,4 +1,4 @@ +> =A0 =A0 =A0 =A0-"Invalid " (2001-01-05) (inbox) +> =A0 =A0 =A0 =A0+Invalid =A0From (2001-01= +-05) (inbox) +> +> If this works for others then the problem is in my setup +> (I have 8 other tests failing for various other reasons) + +This one works for me, but the expected output in my version looks +like: "Invalid " (2001-01-05) (inbox). It looks like that test changed +in part 4 of this series, so maybe something didn't apply properly on +your tree?