From: Robert Mast Date: Wed, 30 Jan 2013 21:49:31 +0000 (+0100) Subject: RE: Reply all - issue X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=92c15d3e67b1e5c71fb8f1fe2e72af4a60eb6bb7;p=notmuch-archives.git RE: Reply all - issue --- diff --git a/72/59cdf7e7349ec831398b0446db154969439b8e b/72/59cdf7e7349ec831398b0446db154969439b8e new file mode 100644 index 000000000..ce22d5349 --- /dev/null +++ b/72/59cdf7e7349ec831398b0446db154969439b8e @@ -0,0 +1,137 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D1749431FAF + for ; Wed, 30 Jan 2013 13:49:48 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 2cGqOQSF0tSP for ; + Wed, 30 Jan 2013 13:49:45 -0800 (PST) +Received: from srv047132.webreus.nl (srv047132.webreus.nl [46.235.47.132]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 71D8B431FAE + for ; Wed, 30 Jan 2013 13:49:45 -0800 (PST) +Received: (qmail 1736 invoked from network); 30 Jan 2013 22:49:44 +0100 +Received: from ip73-109-210-87.adsl2.static.versatel.nl (HELO PCvangebruike) + (87.210.109.73) + by srv047132.webreus.nl with SMTP; 30 Jan 2013 22:49:41 +0100 +From: "Robert Mast" +To: "'Carl Worth'" , "'Jani Nikula'" , + +References: <000001cdfcd9$82500f00$86f02d00$@nl> <87wquxjq7k.fsf@nikula.org> + <002601cdfd83$83b283f0$8b178bd0$@nl> + <87boc8bt8a.fsf@yoom.home.cworth.org> +In-Reply-To: +Subject: RE: Reply all - issue +Date: Wed, 30 Jan 2013 22:49:31 +0100 +Message-ID: <000001cdff33$afe11070$0fa33150$@nl> +MIME-Version: 1.0 +Content-Type: text/plain; + charset="us-ascii" +Content-Transfer-Encoding: 7bit +X-Mailer: Microsoft Office Outlook 12.0 +Thread-Index: Ac39yr2ciHq/BzOAQieJla7aevASjQBP0GPgAAf4vDAAAUOMgA== +Content-Language: nl +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 30 Jan 2013 21:49:49 -0000 + +I ran git send-email and became the following line in the mail-header: + +"X-Mailer: git-send-email 1.7.9.5" + +I see that this git-marker already existed in version 1.3 in 2006: + +http://comments.gmane.org/gmane.comp.version-control.git/23337 + +Can I assume, apart from the version number, that this header-marker applies +to all git-mail that should not be subject-splitted? + +I can also leave the threads in the database as they are and only change +notmuch_query_search_threads in lib/query.cc to add the subject as a second +hash-key and notmuch_threads_get/_notmuch_thread_create for also looking for +the subject of the seed-message. + +Then I only have to add the stripped subject as a search-term. The subject +that's now in the database is the original non-stripped subject. + +I expect next weekend to have some time again. + +-----Oorspronkelijk bericht----- +Van: Robert Mast [mailto:beheerder@tekenbeetziekten.nl] +Verzonden: woensdag 30 januari 2013 21:57 +Aan: 'Carl Worth'; 'Jani Nikula'; 'notmuch@notmuchmail.org' +Onderwerp: RE: Reply all - issue + +I never used git for mailpatching, so I have no example-mailbox to analyse. + +I understand that the subject starting with "[PATCH ]" can be a +git-hint, but is not guaranteed. Or is it? [1] + +If it isn't, can I assume all git-messages comply to this set: [2] + +"The patch is expected to be inline, directly following the message. Any +line that is of the form: + +. three-dashes and end-of-line, or +. a line that begins with "diff -", or +. a line that begins with "Index: " +" + +Or should the git filter also look for a "scissor-line" [3] to identify a +git-message? + +[1] http://www.kernel.org/pub/software/scm/git/docs/git-send-email.html +[2] http://linux.die.net/man/1/git-am +[3] http://linux.die.net/man/1/git-mailinfo + +Or are there any guaranteed under water git-markers in the mailheader? + +-----Oorspronkelijk bericht----- +Van: Robert Mast [mailto:beheerder@tekenbeetziekten.nl] +Verzonden: woensdag 30 januari 2013 18:15 +Aan: 'Carl Worth'; 'Jani Nikula'; 'notmuch@notmuchmail.org' +Onderwerp: RE: Reply all - issue + +Thanks for your clear explanation. + +The thread-merging and breaking is in the procedure already pointed at by +Jani: (_notmuch_database_link_message() in lib/database.cc.) + +Is there a quick way to recognize those git-threads by subject-syntax, or to +reliably tag them to exclude them from subject-breaking? + + + + +-----Oorspronkelijk bericht----- +Van: Carl Worth [mailto:cworth@cworth.org] +Verzonden: dinsdag 29 januari 2013 3:48 +Aan: Robert Mast; 'Jani Nikula'; notmuch@notmuchmail.org +Onderwerp: RE: Reply all - issue + + +Is there any existing thread-breaking? There wasn't the last time I looked +at the code closely, (but admittedly, that was a while ago). + +-Carl + +