From: Ethan Glasser-Camp Date: Fri, 12 Oct 2012 02:21:44 +0000 (+2000) Subject: Re: [notmuch] [PATCH] Calls to notmuch get queued and executed asynchronously. X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=9123fb3b2048777b1cc628d7619912e54bd967b2;p=notmuch-archives.git Re: [notmuch] [PATCH] Calls to notmuch get queued and executed asynchronously. --- diff --git a/fa/9a10ec13c63167f40daf5e97c422ae3c8b48ef b/fa/9a10ec13c63167f40daf5e97c422ae3c8b48ef new file mode 100644 index 000000000..1be1cc1b1 --- /dev/null +++ b/fa/9a10ec13c63167f40daf5e97c422ae3c8b48ef @@ -0,0 +1,89 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6DD6A431FAF + for ; Thu, 11 Oct 2012 19:21:52 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id tR1x6J6Tuf+s for ; + Thu, 11 Oct 2012 19:21:51 -0700 (PDT) +Received: from mail-qa0-f46.google.com (mail-qa0-f46.google.com + [209.85.216.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D58D9431FAE + for ; Thu, 11 Oct 2012 19:21:51 -0700 (PDT) +Received: by mail-qa0-f46.google.com with SMTP id c26so151897qad.5 + for ; Thu, 11 Oct 2012 19:21:50 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=SdkoVvO4FeW0FJ42AS4117DI6SKQxjoLpgUqgXPftVI=; + b=FTV/YDgl2t19C0LItZaoAR+kCBcYOc1IqD9nRUi4kAcDAgtAcw6DlD18B4F5rz1xOJ + /feOChDgDjb17LnmM9R2i9meR3SrJ51T+B7RrYzvje3uE1Zv/iH0bvvsOtNp/grD0yqh + D+H+xoqg/PKeyCwOJ3Eb92pgGTDX9HaY61nwdTWbbQgpYZUhOXhv0qvPqcYOcRrvkxKp + qcQE2ThkLbYQCkT5HupjLkvUN4CFqw1MNeB1yaWRAexJPVUpLATXmnRXR36/it+Z4sHQ + /2U2k+pjHNiZCumxAe4drkWcAe79RjKHGaADloFpDJFZ/OL/WYrk/KpeSPlfoX6XDIfi + FdHQ== +Received: by 10.49.63.104 with SMTP id f8mr6558362qes.29.1350008510046; + Thu, 11 Oct 2012 19:21:50 -0700 (PDT) +Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) + by mx.google.com with ESMTPS id q7sm5451882qeo.6.2012.10.11.19.21.48 + (version=TLSv1/SSLv3 cipher=OTHER); + Thu, 11 Oct 2012 19:21:49 -0700 (PDT) +From: Ethan Glasser-Camp +To: James Vasile , notmuch@notmuchmail.org +Subject: Re: [notmuch] [PATCH] Calls to notmuch get queued and executed + asynchronously. +In-Reply-To: <87vddnlxos.wl%james@hackervisions.org> +References: <87vddnlxos.wl%james@hackervisions.org> +User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 11 Oct 2012 22:21:44 -0400 +Message-ID: <87k3uwzayv.fsf@betacantrips.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 12 Oct 2012 02:21:52 -0000 + +James Vasile writes: + +> Added notmuch-enqueue-asynch to replace calls to +> notmuch-call-notmuch-process. Calls to notmuch are then queued and +> executed asynchronously. If the db is busy and we get an error saying +> it was locked, keep trying until the db is no longer busy. Errors go +> in a buffer as per usual. + +Hi! I decided to review some of the outstanding patches on the nmbug +queue. + +This one doesn't apply cleanly. First, notmuch.el is now in +emacs/. Secondly, tagging happens only one place in notmuch-tag.el. + +The follow-up patch doesn't apply either, and neither does the WIP patch +posted later in the thread by Aaron Ecay. + +It seems like this patch series is useful for some people, but there are +some design issues yet to be worked out. + +I propose that this thread be tagged notmuch::stale. + +Ethan