From: Dmitry Kurochkin Date: Sun, 5 Feb 2012 06:58:04 +0000 (+0400) Subject: Re: [Patch v2 0/4] Control selection of From: header when replying X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=8f98ea3b7253af8d41c3de4f1c6076b0e87535c8;p=notmuch-archives.git Re: [Patch v2 0/4] Control selection of From: header when replying --- diff --git a/0f/b87c3451d0e666d521f0911d4e67e7dd9ea80b b/0f/b87c3451d0e666d521f0911d4e67e7dd9ea80b new file mode 100644 index 000000000..6aece04f5 --- /dev/null +++ b/0f/b87c3451d0e666d521f0911d4e67e7dd9ea80b @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E9852431FAF + for ; Sat, 4 Feb 2012 22:59:24 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id uB3PIoI4Omfr for ; + Sat, 4 Feb 2012 22:59:24 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 25D61431FAE + for ; Sat, 4 Feb 2012 22:59:23 -0800 (PST) +Received: by bke11 with SMTP id 11so4645800bke.26 + for ; Sat, 04 Feb 2012 22:59:21 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=ANKQl7oADfNLZsOxteQJ0UVjCeDUl+9/8CFw9GRlobQ=; + b=C4WimUSB0m+dpkbie5/jTEPF6Cdx3fxVyn+DG0a3nksY6qoRSuPcun1DjtKvJUlUry + mFaQjLnw2YKbY7n0BilqjLKDLcb3d+79X7i4ELKKRotjM4MBr40YqgOE8MiA0hTfysRJ + k/3YKqpp7hIBDEQVoA1Fz6knG1VjkNy16UtoY= +Received: by 10.204.173.11 with SMTP id n11mr6305473bkz.120.1328425161371; + Sat, 04 Feb 2012 22:59:21 -0800 (PST) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id o26sm32855911bko.14.2012.02.04.22.59.19 + (version=TLSv1/SSLv3 cipher=OTHER); + Sat, 04 Feb 2012 22:59:20 -0800 (PST) +From: Dmitry Kurochkin +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [Patch v2 0/4] Control selection of From: header when replying +In-Reply-To: <1328388317-20161-1-git-send-email-markwalters1009@gmail.com> +References: <1328388317-20161-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 05 Feb 2012 10:58:04 +0400 +Message-ID: <87ipjlix6r.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 Feb 2012 06:59:25 -0000 + +Hi Mark. + +I am not sure I like this solution. My concerns are: + +* New option looks too complex, too specific. + +* There are more aspects of notmuch reply behavior which users would + like to change (e.g. which part to quote). If we add an option for + each, we complicate both nomtuch show UI and code. + +The problem is that notmuch show output format is too limiting. Instead +of providing myriad of options for tweaking notmuch show text format +behavior, we should add JSON format for notmuch reply similar to nomtuch +show. That would allow notmuch reply to produce structured output with +required additional information, which should be enough for users to +construct whatever reply they want. + +In this particular case, notmuch reply JSON format could have +"from-source" attribute that would indicate how it was guessed. + +Now the best part. Not so long ago, Adam (in Cc) provided a patch for +improving nomtuch reply for HTML-only emails. At first he added an +option for notmuch reply, like you did for from-guessing. I suggested +him to implement it based on the JSON format instead and he did. AFAIK +the latest version of his patches is [1]. I did not look at the code +though. It seems that it is waiting for more review. + +So, instead of adding more nomtuch show options, I think a better +solution is to work with Adam to get the notmuch reply JSON format to +master and then fix the from-guessing issue by adding an attribute to +notmuch reply JSON format. + +Regards, + Dmitry + +[1] id:"1326995217-27423-1-git-send-email-awg+notmuch@xvx.ca"