From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sun, 15 Apr 2012 17:33:22 +0000 (+0300)
Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the... 
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=8f60220b9e2c26b95704715e17142d6dc6e9d448;p=notmuch-archives.git

Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer.
---

diff --git a/c6/c9d1f17903a5b990ecb453b993bf427a9d7260 b/c6/c9d1f17903a5b990ecb453b993bf427a9d7260
new file mode 100644
index 000000000..88fe1781d
--- /dev/null
+++ b/c6/c9d1f17903a5b990ecb453b993bf427a9d7260
@@ -0,0 +1,108 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 16290431FAF
+	for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 10:33:27 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 9zyYtblCI+-0 for <notmuch@notmuchmail.org>;
+	Sun, 15 Apr 2012 10:33:26 -0700 (PDT)
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
+	by olra.theworths.org (Postfix) with ESMTP id 571AC431FAE
+	for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 10:33:26 -0700 (PDT)
+Received: by guru.guru-group.fi (Postfix, from userid 501)
+	id 2C42E68055; Sun, 15 Apr 2012 20:33:22 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Mark Walters <markwalters1009@gmail.com>, David Edmondson <dme@dme.org>,
+	notmuch@notmuchmail.org
+Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the
+	cursor is at the end of the buffer.
+In-Reply-To: <87lilw6hnw.fsf@qmul.ac.uk>
+References: <1327996914-9644-1-git-send-email-dme@dme.org>
+	<1327996914-9644-3-git-send-email-dme@dme.org>
+	<87lilw6hnw.fsf@qmul.ac.uk>
+User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sun, 15 Apr 2012 20:33:22 +0300
+Message-ID: <m2iph0sxwd.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 15 Apr 2012 17:33:27 -0000
+
+On Sun, Apr 15 2012, Mark Walters wrote:
+
+> On Tue, 31 Jan 2012, David Edmondson <dme@dme.org> wrote:
+>> When using the spacebar to scroll through a thread, hitting 'space'
+>> when the bottom of the last message is visible should take the cursor
+>> to the end of the buffer rather than immediately archiving the thread
+>> and moving to the next thread.
+>
+> Hi
+>
+> This patch looks good to me; (but if people prefer the current behaviour then
+> can we mark this notmuch::wontfix so it leaves the review queue)
+
+I would definitely like to see this patch applied. Less surprising
+as there is no indication we have reached the bottom of the buffer.
+
+> Best wishes
+>
+> Mark
+
+Tomi
+
+
+>
+>> ---
+>>  emacs/notmuch-show.el |    5 +++++
+>>  1 files changed, 5 insertions(+), 0 deletions(-)
+>>
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
+>> index ec72ff8..3f54de0 100644
+>> --- a/emacs/notmuch-show.el
+>> +++ b/emacs/notmuch-show.el
+>> @@ -1319,6 +1319,11 @@ current window), advance to the next open message."
+>>        ;; This is not the last message - move to the next visible one.
+>>        (notmuch-show-next-open-message))
+>>  
+>> +     ((not (= (point) (point-max)))
+>> +      ;; This is the last message, but the cursor is not at the end of
+>> +      ;; the buffer. Move it there.
+>> +      (goto-char (point-max)))
+>> +
+>>       (t
+>>        ;; This is the last message - change the return value
+>>        (setq ret t)))
+>> -- 
+>> 1.7.8.3
+>>
+>> _______________________________________________
+>> notmuch mailing list
+>> notmuch@notmuchmail.org
+>> http://notmuchmail.org/mailman/listinfo/notmuch
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch