From: Michał Górny <mgorny@gentoo.org>
Date: Thu, 23 Feb 2017 18:20:01 +0000 (+0100)
Subject: ruby-fakegem.eclass: Remove completely unnecessary 'eval ls'
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=8e1bff5146ca3f6305ce7349b963c8fa19bc9b63;p=gentoo.git

ruby-fakegem.eclass: Remove completely unnecessary 'eval ls'

Filename expansion is performed when the variable is referenced unquoted
already. There is really no need to call 'ls' on top of that, and even
less reason to wrap it all in 'eval'.
---

diff --git a/eclass/ruby-fakegem.eclass b/eclass/ruby-fakegem.eclass
index 69ab29f7fb85..b1795fa46c93 100644
--- a/eclass/ruby-fakegem.eclass
+++ b/eclass/ruby-fakegem.eclass
@@ -521,9 +521,8 @@ all_fakegem_install() {
 
 		if [[ -d "${bindir}" ]]; then
 			pushd "${bindir}" &>/dev/null || die
-			local binaries=$(eval ls ${RUBY_FAKEGEM_BINWRAP})
-			for binary in $binaries; do
-				ruby_fakegem_binwrapper $binary
+			for binary in ${RUBY_FAKEGEM_BINWRAP}; do
+				ruby_fakegem_binwrapper "${binary}"
 			done
 			popd &>/dev/null || die
 		fi