From: Dmitry Kurochkin Date: Sat, 26 May 2012 01:07:36 +0000 (+0400) Subject: Re: FreeBSD Support Patches X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=8ddc34acb17a99f2b395568b6983d1335b502833;p=notmuch-archives.git Re: FreeBSD Support Patches --- diff --git a/8d/aa76a50dc6484c359025faa899f8ef1e9199f3 b/8d/aa76a50dc6484c359025faa899f8ef1e9199f3 new file mode 100644 index 000000000..6663058bb --- /dev/null +++ b/8d/aa76a50dc6484c359025faa899f8ef1e9199f3 @@ -0,0 +1,127 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id F2AEE431FBC + for ; Fri, 25 May 2012 18:09:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id EeM0NtpnAJ6X for ; + Fri, 25 May 2012 18:09:47 -0700 (PDT) +Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com + [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C125A431FB6 + for ; Fri, 25 May 2012 18:09:46 -0700 (PDT) +Received: by lbbgk8 with SMTP id gk8so1123563lbb.26 + for ; Fri, 25 May 2012 18:09:45 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:content-transfer-encoding; + bh=M2p9nkOnWj+p4wH0fs8BDa4b/yVYgEN3+LRL6RuuVL0=; + b=uA2nrAvDMH2NJofFP41To2CXCuHf9bB1QsQUVwz3GF3zScGv5uyRbojBKYr3OFZNDo + H4klSg+XhQP0ztuKIuVxMhyxt4i7OohAmJLMLHWMfLp5/eLT7a8tEmNCHNsb2dAFemfI + yjy6Ulw+CNttiw5l/Z8tqlJbxn71uj0bRacbseHz5csEANZ7vONJFzScryTBGAqfqv4/ + wtIwP6gVV2cWMoooQg/cUullE4kn1d5MmGd7YZ/yn145ngIl3/PmoJAp6uKL/6hD2rd8 + +or2kRJ7oiz7cD9sxgrUFbuKeZyFVWHN7h4KIMk6PmcAILY2WIp10Y0Z2gPTrEa8jr3S + so5w== +Received: by 10.152.148.34 with SMTP id tp2mr765889lab.47.1337994585206; + Fri, 25 May 2012 18:09:45 -0700 (PDT) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id lv13sm6333203lab.8.2012.05.25.18.09.43 + (version=TLSv1/SSLv3 cipher=OTHER); + Fri, 25 May 2012 18:09:44 -0700 (PDT) +From: Dmitry Kurochkin +To: Mike Kelly +Subject: Re: FreeBSD Support Patches +In-Reply-To: + +References: <1337953411-21000-1-git-send-email-pioto@pioto.org> + <87ipfktkgy.fsf@gmail.com> + +User-Agent: Notmuch/0.13+30~g6d44c5a (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 26 May 2012 05:07:36 +0400 +Message-ID: <87aa0vu4vb.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 26 May 2012 01:09:49 -0000 + +Mike Kelly writes: + +> On Fri, May 25, 2012 at 10:15 AM, Dmitry Kurochkin +> wrote: +>> Why do we need to explicitly declare Emacs dependency for tests? =C2=A0T= +here +>> should be no need for it. =C2=A0We have "implicit" dependencies which are +>> declared once (see test_declare_external_prereq calls at the end of +>> test-lib.sh) and are automatically handled when a test tries to use a +>> missing binary. =C2=A0Explicit dependencies are hard to maintain (e.g. y= +our +>> patch adds explicit emacs dependency for crypto test but misses gpg). +>> With rare exceptions we should not use explicit dependencies. +> +> Because not every test actually has those implicit dependencies. For +> example, some of the crypto tests depend upon emacs_deliver_message +> working correctly for subsequents tests. Those emacs_deliver_message +> tests are skipped, but not the ones after it that try to do something +> with that injected message. +> +> For the emacs-* test files, there are some tests that act the same +> way. + +These subtests do not directly depend on Emacs. They depend on other +subtests. Currently, we do not support such dependencies. But what you +propose is not the solution. We have two options here: make all +subtests independent or introduce proper subtests dependencies. The +former might require many changes to existing tests and may be hard to +enforce. The latter is not trivial as well but is doable. I planned to +implement subtests dependencies but never really got to it (and I do not +think I will anytime soon). + +> However, it is also a minor speed improvement to say that, +> obviously, none of the emacs tests are going to work, so just don't +> bother. +> + +I do not think maintaining an explicit list of dependencies worth a +minor speed improvement. + +Given all above, I understand that your patches fix a common problem in +a simple way. And it does not look like we would get proper solution +anytime soon. So I am ok with these patches with two comments: + + * Provide a proper commit message to explain the issue in more detail. + + * Add an XXX comment for each explicit dependency, something like: + + // XXX: Workaround for subtests that depend on other subtests (and, + // hence, indirectly depend on emacs). Should be removed when we + // have proper subtests dependencies. + +Regards, + Dmitry + +> --=20 +> Mike Kelly