From: Mark Walters Date: Tue, 4 Dec 2012 23:27:39 +0000 (+0000) Subject: [PATCH 0/3] Use invisibility to toggle display of all parts including multipart X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=8b7b672436365670623ef1928799252320cfa1e6;p=notmuch-archives.git [PATCH 0/3] Use invisibility to toggle display of all parts including multipart --- diff --git a/30/387297662ac335890bc94053eefe6de278546d b/30/387297662ac335890bc94053eefe6de278546d new file mode 100644 index 000000000..0f92f5dc2 --- /dev/null +++ b/30/387297662ac335890bc94053eefe6de278546d @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5C168431FB6 + for ; Tue, 4 Dec 2012 15:27:49 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.7 +X-Spam-Level: ** +X-Spam-Status: No, score=2.7 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id r9T9CHLIc9JJ for ; + Tue, 4 Dec 2012 15:27:49 -0800 (PST) +Received: from mail-we0-f181.google.com (mail-we0-f181.google.com + [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C237F431FAE + for ; Tue, 4 Dec 2012 15:27:48 -0800 (PST) +Received: by mail-we0-f181.google.com with SMTP id t11so2167249wey.26 + for ; Tue, 04 Dec 2012 15:27:47 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer; + bh=SG4hZ0hZwBFuNPS0upXq+6Xx0/ioL7bO+x4Up5/EYR0=; + b=XELsbyup+11xVL2sapRPnq1FbUilOimJ5mnFteepDAdgSG6a8dlrhiWBsknbxMwNQU + wcsc42ZyFdAHOgrnT8Z3OMHGRoMGKvx3CshmiV4DznK2KxdrIM5FZD4KEIOQ8fC/AKNx + meYVS2G2/iyQNihox7jhT8wMO17vhaax+sz+hFktDhLBUDZO1x+5HdV2eQFPs0bP3kRB + uuYSvaApBguPHXXO1XbnsW5bkBCURrVjzKjkT70BuQwyFgiqjBUQehf9G7JWmakWwByt + TgA8n301IFExTVqVQo8IOBNcRkkfhZ+2kG7S5dlvnhagGc92Nfu6jBLz0v1dYJofHxC0 + faag== +Received: by 10.180.88.71 with SMTP id be7mr28124wib.17.1354663666160; + Tue, 04 Dec 2012 15:27:46 -0800 (PST) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPS id t17sm3999400wiv.6.2012.12.04.15.27.44 + (version=TLSv1/SSLv3 cipher=OTHER); + Tue, 04 Dec 2012 15:27:45 -0800 (PST) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 0/3] Use invisibility to toggle display of all parts including + multipart +Date: Tue, 4 Dec 2012 23:27:39 +0000 +Message-Id: <1354663662-20524-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Dec 2012 23:27:49 -0000 + +This patch aims to do the same as +id:1354496317-24564-1-git-send-email-markwalters1009@gmail.com but +rather than reloading the buffer it uses invisibility. + +Most of the invisibility stuff was taken from notmuch-wash and adapted +to this situation. + +The general interface is that any part can have its visibility +toggled: in this version by "t" on the part button. In addition "RET" +on the part button of any "not shown" part will show it. + +Whilst a main driver was being able to view different parts of a +multipart/alternative message, this also allows the user to toggle +images or large inline text attachments (eg text/x-tex) for +example. Indeed, even multipart part buttons can be toggled which +remove the whole tree beneath: it is unclear whether this last is useful. + +The invisibility approach has some advantages over the reloading +approach. It does not disrupt the rest of the buffer (eg +collapsed/expanded citations remain), it does not require an extra +call to the database with the possible addition of messages to the +buffer, and it fits more naturally with the other hidden/not-hidden +items. + +Best wishes + +Mark + + +Mark Walters (3): + emacs: show: modify insert-part-header to save the button text + emacs: show: add overlays for each part + emacs: show: add invisibility button action + + emacs/notmuch-show.el | 117 +++++++++++++++++++++++++++++++++++++++---------- + 1 files changed, 93 insertions(+), 24 deletions(-) + +-- +1.7.9.1 +