From: david Date: Sun, 16 Dec 2012 20:16:34 +0000 (+2000) Subject: proposed fix for memory leak in notmuch restore X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=8a5feaa4f8c65fbe87480e699c29f66ad3ed742a;p=notmuch-archives.git proposed fix for memory leak in notmuch restore --- diff --git a/af/eb3b99f6a44a04c668d9fdc42e3f1921238f47 b/af/eb3b99f6a44a04c668d9fdc42e3f1921238f47 new file mode 100644 index 000000000..73ac0bb46 --- /dev/null +++ b/af/eb3b99f6a44a04c668d9fdc42e3f1921238f47 @@ -0,0 +1,57 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D3135431FC4 + for ; Sun, 16 Dec 2012 12:16:56 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id f0PpzuXiTW-P for ; + Sun, 16 Dec 2012 12:16:56 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6CB70431FAE + for ; Sun, 16 Dec 2012 12:16:56 -0800 (PST) +Received: from fctnnbsc30w-142167090129.dhcp-dynamic.fibreop.nb.bellaliant.net + ([142.167.90.129] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) id 1TkKdo-0007ta-SX + for notmuch@notmuchmail.org; Sun, 16 Dec 2012 16:16:53 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) id 1TkKdj-00050W-E1 + for notmuch@notmuchmail.org; Sun, 16 Dec 2012 16:16:47 -0400 +From: david@tethera.net +To: notmuch@notmuchmail.org +Subject: proposed fix for memory leak in notmuch restore +Date: Sun, 16 Dec 2012 16:16:34 -0400 +Message-Id: <1355688997-19164-1-git-send-email-david@tethera.net> +X-Mailer: git-send-email 1.7.10.4 +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 16 Dec 2012 20:16:57 -0000 + +In id:87vcc2q5n2.fsf@nikula.org, Jani points out a memory leak in the +new restore code. This series is a proposed fix, namely do any +allocation on a temporary talloc context that is destroyed after each +line is processed. + +