From: Carl Worth Date: Wed, 27 Jun 2012 16:46:05 +0000 (+1700) Subject: [PATCH] Restore original keybinding ('r' = reply-to-all) X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=8686c56d7e3e067eb77fe8aebee147a6964d89c6;p=notmuch-archives.git [PATCH] Restore original keybinding ('r' = reply-to-all) --- diff --git a/73/dc1a87f6dc4e5a469f20a5d5814208b0843b55 b/73/dc1a87f6dc4e5a469f20a5d5814208b0843b55 new file mode 100644 index 000000000..33f9b0722 --- /dev/null +++ b/73/dc1a87f6dc4e5a469f20a5d5814208b0843b55 @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 55D06431FAF + for ; Wed, 27 Jun 2012 09:45:03 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id kn58lznsirsy for ; + Wed, 27 Jun 2012 09:45:02 -0700 (PDT) +Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A3EFD431FB6 + for ; Wed, 27 Jun 2012 09:45:02 -0700 (PDT) +Received: from yoom.amr.corp.intel.com (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 1FEF929A053; + Wed, 27 Jun 2012 09:45:01 -0700 (PDT) +From: Carl Worth +To: notmuch@notmuchmail.org +Subject: [PATCH] Restore original keybinding ('r' = reply-to-all) +Date: Wed, 27 Jun 2012 09:46:05 -0700 +Message-Id: <1340815565-21083-1-git-send-email-cworth@cworth.org> +X-Mailer: git-send-email 1.7.10 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 27 Jun 2012 16:45:03 -0000 + +Since the beginning of time, the emacs interface provided a keybinding +of 'r' to reply to a message, (and originally, all recipients). + +Then, before release 0.12 the emacs interface acquired a new +reply-to-sender only feature. In commit +f02b475fa781bb5df3358c73213e7633a99f016e the new feature was put onto +the original keybinding, (and reply-to-all was moved to 'R'). + +This restores the original keybinding and uses the new keybinding for +the new feature. +--- + +The commit message above motivates this change from the point of view +of interface compatibility. That argument would have been stronger if +I had made it in January, (at the time of the change), rather than +now, (since there's now a new incompatiblity made by changing things +back). + +That said, I still think the compatibility argument is sound. + +I have other feelings as to which reply behavior should be treated +preferentially. But those are potentially more controversial, so I'll +leave the bikeshedding out of our commit history. + +Thanks to everyone keeping notmuch alive and well during my extended +absence from maintainership. What a tremendous free-software success +story this all is. I'm so grateful to all of you. + +-Carl + + emacs/notmuch-show.el | 4 ++-- + emacs/notmuch.el | 4 ++-- + 2 files changed, 4 insertions(+), 4 deletions(-) + +diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +index 4349836..399a8bd 100644 +--- a/emacs/notmuch-show.el ++++ b/emacs/notmuch-show.el +@@ -1145,8 +1145,8 @@ reset based on the original query." + (define-key map "s" 'notmuch-search) + (define-key map "m" 'notmuch-mua-new-mail) + (define-key map "f" 'notmuch-show-forward-message) +- (define-key map "r" 'notmuch-show-reply-sender) +- (define-key map "R" 'notmuch-show-reply) ++ (define-key map "r" 'notmuch-show-reply) ++ (define-key map "R" 'notmuch-show-reply-sender) + (define-key map "|" 'notmuch-show-pipe-message) + (define-key map "w" 'notmuch-show-save-attachments) + (define-key map "V" 'notmuch-show-view-raw-message) +diff --git a/emacs/notmuch.el b/emacs/notmuch.el +index c6236db..3a6b025 100644 +--- a/emacs/notmuch.el ++++ b/emacs/notmuch.el +@@ -215,8 +215,8 @@ For a mouse binding, return nil." + (define-key map ">" 'notmuch-search-last-thread) + (define-key map "p" 'notmuch-search-previous-thread) + (define-key map "n" 'notmuch-search-next-thread) +- (define-key map "r" 'notmuch-search-reply-to-thread-sender) +- (define-key map "R" 'notmuch-search-reply-to-thread) ++ (define-key map "r" 'notmuch-search-reply-to-thread) ++ (define-key map "R" 'notmuch-search-reply-to-thread-sender) + (define-key map "m" 'notmuch-mua-new-mail) + (define-key map "s" 'notmuch-search) + (define-key map "o" 'notmuch-search-toggle-order) +-- +1.7.10 +