From: Jani Nikula Date: Sun, 5 Feb 2012 13:12:14 +0000 (+0200) Subject: Re: [Patch v2 0/4] Control selection of From: header when replying X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=85dfec860e828a5bcea3f6d0a2851539fb0f955b;p=notmuch-archives.git Re: [Patch v2 0/4] Control selection of From: header when replying --- diff --git a/15/9bb97495f9f83ab2f99f0b2e587cbc07ace9dd b/15/9bb97495f9f83ab2f99f0b2e587cbc07ace9dd new file mode 100644 index 000000000..fb3e5efed --- /dev/null +++ b/15/9bb97495f9f83ab2f99f0b2e587cbc07ace9dd @@ -0,0 +1,122 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id F307A431FAF + for ; Sun, 5 Feb 2012 05:12:22 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id O4JxxKDqPkrK for ; + Sun, 5 Feb 2012 05:12:22 -0800 (PST) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 0323E431FAE + for ; Sun, 5 Feb 2012 05:12:21 -0800 (PST) +Received: by lahd3 with SMTP id d3so2875264lah.26 + for ; Sun, 05 Feb 2012 05:12:20 -0800 (PST) +Received: by 10.152.123.68 with SMTP id ly4mr1987063lab.13.1328447538847; + Sun, 05 Feb 2012 05:12:18 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-fe50f800-253.dhcp.inet.fi. + [84.248.80.253]) + by mx.google.com with ESMTPS id z2sm10271622lbk.7.2012.02.05.05.12.15 + (version=SSLv3 cipher=OTHER); Sun, 05 Feb 2012 05:12:17 -0800 (PST) +From: Jani Nikula +To: Dmitry Kurochkin , + Mark Walters , notmuch@notmuchmail.org +Subject: Re: [Patch v2 0/4] Control selection of From: header when replying +In-Reply-To: <87ipjlix6r.fsf@gmail.com> +References: <1328388317-20161-1-git-send-email-markwalters1009@gmail.com> + <87ipjlix6r.fsf@gmail.com> +User-Agent: Notmuch/0.11+139~g4340989 (http://notmuchmail.org) Emacs/23.3.1 + (i686-pc-linux-gnu) +Date: Sun, 05 Feb 2012 15:12:14 +0200 +Message-ID: <877h01a0gh.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 Feb 2012 13:12:23 -0000 + +On Sun, 05 Feb 2012 10:58:04 +0400, Dmitry Kurochkin wrote: +> Hi Mark. +> +> I am not sure I like this solution. My concerns are: +> +> * New option looks too complex, too specific. + +*shrug* The --from parameter is simple to implement, simple to test, and +simple to use. + +> * There are more aspects of notmuch reply behavior which users would +> like to change (e.g. which part to quote). If we add an option for +> each, we complicate both nomtuch show UI and code. + +This I agree is more of an issue. + +> The problem is that notmuch show output format is too limiting. Instead +> of providing myriad of options for tweaking notmuch show text format +> behavior, we should add JSON format for notmuch reply similar to nomtuch +> show. That would allow notmuch reply to produce structured output with +> required additional information, which should be enough for users to +> construct whatever reply they want. + +Heh, when I told Mark on IRC to just send the patches and not discuss +and worry about it too much, I added "...and then someone will come up +with an approach we failed to think of, and scrap the whole +thing". Thanks Dmitry! ;) + +> In this particular case, notmuch reply JSON format could have +> "from-source" attribute that would indicate how it was guessed. + +My first thought is that it's offloading things that are trivial in the +cli to the users of the cli where it might be slightly more complicated, +but... + +> Now the best part. Not so long ago, Adam (in Cc) provided a patch for +> improving nomtuch reply for HTML-only emails. At first he added an +> option for notmuch reply, like you did for from-guessing. I suggested +> him to implement it based on the JSON format instead and he did. AFAIK +> the latest version of his patches is [1]. I did not look at the code +> though. It seems that it is waiting for more review. +> +> So, instead of adding more nomtuch show options, I think a better +> solution is to work with Adam to get the notmuch reply JSON format to +> master and then fix the from-guessing issue by adding an attribute to +> notmuch reply JSON format. + +...no matter what the solution will be in the end, I agree it's best to +get Adam's work merged first, and see how easily this can be handled +using JSON vs. the parameter. + +Thanks for your insights. + + +BR, +Jani. + + +> Regards, +> Dmitry +> +> [1] id:"1326995217-27423-1-git-send-email-awg+notmuch@xvx.ca" +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch