From: Jameson Graef Rollins Date: Wed, 1 Feb 2012 08:47:30 +0000 (+1600) Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=82af2e02f03065448b1a92514f713ef6841d29d8;p=notmuch-archives.git Re: [PATCH] test: make test_expect_equal_file() arguments flexible --- diff --git a/11/cf6225437e40556edb51d9f8202b5496cbf638 b/11/cf6225437e40556edb51d9f8202b5496cbf638 new file mode 100644 index 000000000..40145c459 --- /dev/null +++ b/11/cf6225437e40556edb51d9f8202b5496cbf638 @@ -0,0 +1,93 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A3533431E64 + for ; Wed, 1 Feb 2012 00:47:47 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id YfsPsHnH+0bf for ; + Wed, 1 Feb 2012 00:47:46 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id D1E60431FAF + for ; Wed, 1 Feb 2012 00:47:46 -0800 (PST) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id 378E22E50E5F; + Wed, 1 Feb 2012 00:47:44 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com + [76.174.137.84]) (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id 746C82E50D46; + Wed, 1 Feb 2012 00:47:34 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id B9987291; Wed, 1 Feb 2012 00:47:33 -0800 (PST) +From: Jameson Graef Rollins +To: Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible +In-Reply-To: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com> +References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com> +User-Agent: Notmuch/0.11+128~g6f388fa (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 01 Feb 2012 00:47:30 -0800 +Message-ID: <87r4yfszx9.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 01 Feb 2012 08:47:47 -0000 + +--=-=-= + +On Wed, 1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin wrote: +> The down side of this approach is that diff argument order depends on +> test_expect_equal_file() argument order. So sometimes we get diff +> from expected to actual results, and sometimes the other way around. +> But the files are always named correctly. + +Actually, I think this last point is the most important thing to retain. +Consistency in the diffs makes reading test results much more efficient. +The order I don't much care about. But seeing as we have been +consistent with a particular order for a while, it seems like more +effort than it's worth to change it. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iQIcBAEBCAAGBQJPKPwjAAoJEO00zqvie6q8ptIP+wTZveaN5Cq04UsIjSi/shdL +qrjvzOMMqT+gQC13PRpeFmYEklL5Xa3F9FTmyGaiEtv7dQG9GJ70ii8c7kRObZzO +7DkZFu4n2o4wSmfTVBh6arX5fJbBY/1rb8nnq7SltTJ/FTaPv/C4tquQY32YKb4d +jpPGWRt+zntKk4U4BE+djHGuoLO4/f5ru4ZwAPKt0AKJv2VK8IJus6gVQdG9rxDp +abuAwnzc75Wy5wzi1mkyQjdFCH36GwNTZfj8Iu46PmZcDb/iPLJZ4o8aYZI47vU2 +KrLiNHjyg5amWoCh51YQrh16g2OpssmxZ3CA2ZcqIaAE4TSH/YDv98ZYOkCE6CLa +X1JWpDrsZRbqqWOqnhU45cKJh6Iia84voloAIu0FoDwmT0VdE7SQIr3FNC6DaUJH +Ygzlug7I5Sl5fVH1rMxGbnq7r716XPjhacTcfRP/daXG/8+2bSvHDqO6zhmTryaq +klzGTUJF4SovfVjJmHSqJFcTT+a7r3r/7nLILIYcdDLS1xtFJO3//xMTw31tZepp +/efN+0MtW3lFLl+jUvoqN7R47d5M5UHClcl81W43fC165uSoXAOidv5d5uQjpNJg +IuOEzpwSrVXNE9OfXrc+WX29l46YNDOzGm2mCzTzibNnwTG7TDabWcGkdSRFbIOT +70QnD6m/z19ovoaOyYcW +=os7l +-----END PGP SIGNATURE----- +--=-=-=--