From: Mark Walters Date: Sun, 12 Feb 2012 22:08:45 +0000 (+0000) Subject: Re: [RFC PATCH v2 1/3] cli: notmuch-show changes to support pick X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=821efa6023c0739e1fdf91602951fc06cf5d46bb;p=notmuch-archives.git Re: [RFC PATCH v2 1/3] cli: notmuch-show changes to support pick --- diff --git a/ab/0fd4279e9cae2fe72bfcad83d3a2b2c26f7d94 b/ab/0fd4279e9cae2fe72bfcad83d3a2b2c26f7d94 new file mode 100644 index 000000000..d7c5cfc1b --- /dev/null +++ b/ab/0fd4279e9cae2fe72bfcad83d3a2b2c26f7d94 @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5EB0F429E52 + for ; Sun, 12 Feb 2012 14:07:27 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id gp0XlqA8ZoVc for ; + Sun, 12 Feb 2012 14:07:27 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C5B7E431FAE + for ; Sun, 12 Feb 2012 14:07:26 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1RwhZt-0002Hj-DI; Sun, 12 Feb 2012 22:07:25 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1RwhZt-0003Wa-4S; Sun, 12 Feb 2012 22:07:25 +0000 +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: Re: [RFC PATCH v2 1/3] cli: notmuch-show changes to support pick +In-Reply-To: <1329072579-27340-2-git-send-email-markwalters1009@gmail.com> +References: <1329072579-27340-1-git-send-email-markwalters1009@gmail.com> + <1329072579-27340-2-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.11.1+192~g23e894e (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Sun, 12 Feb 2012 22:08:45 +0000 +Message-ID: <87wr7rr9g2.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: e6bee611ba0e24ef2dacd955144aecb9 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 12 Feb 2012 22:07:27 -0000 + + +This patch adds the following features to notmuch-show.c + +a --headers-only option which just outputs the headers of a message +(i.e. it omits the bodies). This is not strictly needed by +notmuch-pick.el but it gives a speed-up of at least a factor of a two; +moreover it reduces the memory usage of the emacs part hugely. + +a --sort=oldest-first|newest-first option to allow notmuch-pick.el to +choose the sort order. + +a --thread=none option to tell it to return just the matching messages +with not threading information at all. This is used by notmuch-pick.el +to display an unthreaded message view (e.g., for an inbox). It is also +useful for displaying a single message in the pick view as show is much +faster at showing a single message than the whole thread. + +The other options for --thread of --thread=entire|match replace the +--entire-thread option. + +Presumably this should really be split into three separate patches, but +advice on this is gratefully received! + +Thanks + +Mark +