From: Michal Sojka Date: Thu, 6 Sep 2012 12:39:14 +0000 (+0200) Subject: Re: [PATCH v2] emacs: Add customization group for replying X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=806fe1453abf14041a7a6cbe5ce4420cda4077a4;p=notmuch-archives.git Re: [PATCH v2] emacs: Add customization group for replying --- diff --git a/3f/fe73d26d9bb58de95cd9dd777c7344daab0fc5 b/3f/fe73d26d9bb58de95cd9dd777c7344daab0fc5 new file mode 100644 index 000000000..305833d96 --- /dev/null +++ b/3f/fe73d26d9bb58de95cd9dd777c7344daab0fc5 @@ -0,0 +1,144 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4F3B7431FAF + for ; Thu, 6 Sep 2012 05:39:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id EUG3XtiA8vfN for ; + Thu, 6 Sep 2012 05:39:21 -0700 (PDT) +Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) + by olra.theworths.org (Postfix) with ESMTP id 1F725431FAE + for ; Thu, 6 Sep 2012 05:39:21 -0700 (PDT) +Received: from localhost (unknown [192.168.200.4]) + by max.feld.cvut.cz (Postfix) with ESMTP id 6534B19F3333; + Thu, 6 Sep 2012 14:39:16 +0200 (CEST) +X-Virus-Scanned: IMAP AMAVIS +Received: from max.feld.cvut.cz ([192.168.200.1]) + by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, + port 10044) + with ESMTP id xfJ4XuCkEyzi; Thu, 6 Sep 2012 14:39:14 +0200 (CEST) +Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) + by max.feld.cvut.cz (Postfix) with ESMTP id BA8AD19F2F4D; + Thu, 6 Sep 2012 14:39:14 +0200 (CEST) +Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30]) + (Authenticated sender: sojkam1) + by imap.feld.cvut.cz (Postfix) with ESMTPSA id 7F66D660904; + Thu, 6 Sep 2012 14:39:14 +0200 (CEST) +Received: from wsh by steelpick.2x.cz with local (Exim 4.80) + (envelope-from ) + id 1T9bMY-0000pr-BP; Thu, 06 Sep 2012 14:39:14 +0200 +From: Michal Sojka +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] emacs: Add customization group for replying +In-Reply-To: +References: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz> + +User-Agent: Notmuch/0.14+23~g9d68aca (http://notmuchmail.org) Emacs/24.1.1 + (x86_64-pc-linux-gnu) +Date: Thu, 06 Sep 2012 14:39:14 +0200 +Message-ID: <87y5kntjf1.fsf@steelpick.2x.cz> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 06 Sep 2012 12:39:22 -0000 + +On Thu, Sep 06 2012, Tomi Ollila wrote: +> On Thu, Sep 06 2012, Michal Sojka wrote: +> +>> When one wants to customize the format of reply message, there is nothing +>> to tell the user how to do it. Without knowing that construction of +>> reply buffer is actually implemented in the message package, it seems +>> that replying cannot be customized. +>> +>> Because I was getting annoyed by the empty line the between the citation +>> line and the quoted message, I figured out that changing this is fairly +>> easy when one knows what to customize. +>> +>> This patch adds notmuch-reply customization group that contains +>> references to the relevant customization options. The new group is easy +>> to find as it is shown as a result of running "M-x customize-group RET +>> notmuch RET". +>> --- +> +> So far good, but... +> +> You forgot to handle the current group setting for +> notmuch-message-replied-tags -- currently notmuch-message.el has this: +> +> (defcustom notmuch-message-replied-tags '("replied") +> "Tags to be automatically added to or removed from a message when it is +> replied to. +> Any tag in the list will be added to a replied message or, +> if it is prefaced with a \"-\", removed. +> +> For example, if you wanted to add a \"replied\" tag and remove +> the \"inbox\" and \"todo\", you would set +> (\"replied\" \"-inbox\" \"-todo\"\)" +> :type 'list +> :group 'notmuch-send) +> +> If the above was changed to 'normuch-send, (require 'notmuch-lib) +> was added to the beginning of notmuch-message.el and the defgroup +> below was written as +> +> (defgroup notmuch-reply +> '((message-insertion custom-group))) +> "Replying to messages. +> ... +> +> would that work as expected ? + +Hi Tomi, + +I don't really get what are you trying to say. Do you mean that +notmuch-message-replied-tags is referenced from notmuch-lib.el without +(require 'notmuch-message)? I'm not sure whether it is required, but it +works here without problems. + +Running M-x customize-variable RET notmuch-message-replied-tags RET +shows the following. Note that both groups are mentioned at the bottom. +No warning or errors are produced. + +-Michal + +--8<---------------cut here---------------start------------->8--- +To apply changes, use the Save or Set buttons. +For details, see Saving Customizations in the Emacs manual. + + Search + + Operate on all settings in this buffer: + Set for current session Save for future sessions + Undo edits Reset to saved Erase customizations Exit + +Hide notmuch-message-replied-tags: '("replied") + State : STANDARD. (mismatch) + Tags to be automatically added to or removed from a message when it is replied to. Hide + Any tag in the list will be added to a replied message or, + if it is prefaced with a "-", removed. + + For example, if you wanted to add a "replied" tag and remove + the "inbox" and "todo", you would set + ("replied" "-inbox" "-todo") +Groups: Notmuch Send Notmuch Reply +--8<---------------cut here---------------end--------------->8--- +