From: Mark Walters Date: Tue, 6 Mar 2012 21:22:55 +0000 (+0000) Subject: Re: [PATCH v2 3/8] show: Allow formatters to return errors X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=7a6eb182469f1d8a88cab8c264fc893cff3beea7;p=notmuch-archives.git Re: [PATCH v2 3/8] show: Allow formatters to return errors --- diff --git a/15/2a27a87b33c90e9533163b993e266729beec30 b/15/2a27a87b33c90e9533163b993e266729beec30 new file mode 100644 index 000000000..f3627cd22 --- /dev/null +++ b/15/2a27a87b33c90e9533163b993e266729beec30 @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 22EBA431FBC + for ; Tue, 6 Mar 2012 13:21:12 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id zi8XFksQElLS for ; + Tue, 6 Mar 2012 13:21:11 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 354EF431FAE + for ; Tue, 6 Mar 2012 13:21:11 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1S51od-0007AH-Fd; Tue, 06 Mar 2012 21:21:06 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1S51od-0003zy-6D; Tue, 06 Mar 2012 21:21:03 +0000 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 3/8] show: Allow formatters to return errors +In-Reply-To: <1331059724-14653-4-git-send-email-amdragon@mit.edu> +References: <1330752025-2542-1-git-send-email-amdragon@mit.edu> + <1331059724-14653-1-git-send-email-amdragon@mit.edu> + <1331059724-14653-4-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.11.1+308~gb2dba53 (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Tue, 06 Mar 2012 21:22:55 +0000 +Message-ID: <87ipihbf0w.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 8afa1fc334f018ecd65dda0dc556ab7d (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 06 Mar 2012 21:21:12 -0000 + +On Tue, 6 Mar 2012 18:48:39 +0000, Austin Clements wrote: +> Formatter errors are propagated to the exit status of notmuch show. +> +> This isn't used by the JSON or text formatters, but it will be useful +> for the raw format, which is pickier. + +I am not very familiar with this part of the code but the whole series +looks fine to me. + +My only minor comment is that I like Tom's suggestion (in +id:"m2399qrtat.fsf@guru.guru-group.fi") of having NOTMUCH_STATUS_FAILURE +(= 1) to make the error handling look cleaner. Alternatively (or +possibly as well) the functions do_show and do_show_messages could pass +the actual error back up to notmuch_show_command and then that function +could convert return 0/1 as appropriate. + +As usual I am quite happy to be overruled! + +Best wishes + +Mark