From: Austin Clements Date: Fri, 23 Nov 2012 20:39:18 +0000 (+1900) Subject: Re: [PATCH 2/3] cli: all search mode to include msg-ids with JSON output X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=7a09474d9d91657ecdcd1ad3d967c77297f3ff27;p=notmuch-archives.git Re: [PATCH 2/3] cli: all search mode to include msg-ids with JSON output --- diff --git a/66/b9b64f9c388e64652ec6f4d8dadbef6010b9d7 b/66/b9b64f9c388e64652ec6f4d8dadbef6010b9d7 new file mode 100644 index 000000000..dd9fadca3 --- /dev/null +++ b/66/b9b64f9c388e64652ec6f4d8dadbef6010b9d7 @@ -0,0 +1,95 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 06DD6431FAF + for ; Fri, 23 Nov 2012 12:39:22 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id FZAkJlZKT8ud for ; + Fri, 23 Nov 2012 12:39:21 -0800 (PST) +Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU + [18.7.68.36]) + by olra.theworths.org (Postfix) with ESMTP id 6E64B431FAE + for ; Fri, 23 Nov 2012 12:39:21 -0800 (PST) +X-AuditID: 12074424-b7fce6d000000925-0e-50afdef85bb7 +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP + id B6.F6.02341.8FEDFA05; Fri, 23 Nov 2012 15:39:20 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id qANKdJoK027888; + Fri, 23 Nov 2012 15:39:20 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qANKdI7p025304 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Fri, 23 Nov 2012 15:39:19 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1Tc01u-0007Ea-3V; Fri, 23 Nov 2012 15:39:18 -0500 +Date: Fri, 23 Nov 2012 15:39:18 -0500 +From: Austin Clements +To: Jameson Graef Rollins +Subject: Re: [PATCH 2/3] cli: all search mode to include msg-ids with JSON + output +Message-ID: <20121123203918.GG4562@mit.edu> +References: <1352487491-31512-1-git-send-email-markwalters1009@gmail.com> + <1352487491-31512-3-git-send-email-markwalters1009@gmail.com> + <87y5hty5q2.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87y5hty5q2.fsf@servo.finestructure.net> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42IRYrdT0f1xb32AQfsyU4s9+7wsVs/lsbh+ + cyazA7PH3dNcHjtn3WX3eLbqFnMAcxSXTUpqTmZZapG+XQJXxoQ1HAXL2Cv2/09vYHzN2sXI + wSEhYCJxcIdwFyMnkCkmceHeerYuRi4OIYF9jBIT5qxmh3A2MEpc7/zGCOFcZJJ4/uIIM4Sz + hFHizo5fTCD9LAKqEjcaprCC2GwCGhLb9i9nBLFFBMwker78AbOZBVwlZlzYBVYvLBAscfTS + BDCbV0BbYtOu6SwgtpDAFkaJa/fdIeKCEidnPmGB6NWSuPHvJRPI2cwC0hLL/3GAhDkFTCXm + /5/HDmKLCqhITDm5jW0Co9AsJN2zkHTPQuhewMi8ilE2JbdKNzcxM6c4NVm3ODkxLy+1SNdc + LzezRC81pXQTIzjAXVR2MDYfUjrEKMDBqMTDm3BmfYAQa2JZcWXuIUZJDiYlUV6xG0AhvqT8 + lMqMxOKM+KLSnNTiQ4wSHMxKIrxfK4ByvCmJlVWpRfkwKWkOFiVx3uspN/2FBNITS1KzU1ML + UotgsjIcHEoSvPvuAjUKFqWmp1akZeaUIKSZODhBhvMADde9BzK8uCAxtzgzHSJ/ilFRSpz3 + PkizAEgiozQPrheWgF4xigO9Isz7DqSKB5i84LpfAQ1mAhr8dPY6kMEliQgpqQbG7krthg3d + jxS5ZmctC15pv+BYmOne1O/z7jSrXwn8uPPa1S3LM0MWPBD5HseXf4vXYsLmt/WvvpV8dT36 + q/+rU4jFts3nX0+WErm6x3fvzVMiB/Qj+7vLX7DGXL4ffXbT+fDvNy777fLQ8t3k0+7s5H7j + CnuApIdf9s0H1/QfbX/CmJc7q3KdhRJLcUaioRZzUXEiADnsSBIbAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 23 Nov 2012 20:39:22 -0000 + +Quoth Jameson Graef Rollins on Nov 22 at 8:15 am: +> On Fri, Nov 09 2012, Mark Walters wrote: +> > This adds a --output=with-ids option which gives similar output to the +> > normal search summary output but with a list of message ids +> > too. Currently this is not implemented for text format. +> +> Hey, Mark. Very nit-picky comment here, but I'm not sure "with-ids" is +> an appropriate name for an output type. "with-ids" sounds like a +> modifier, as opposed to a output type unto itself. + +In fact, it sounds so much like a modifier that I wonder if it should +be implemented as a modifier. This isn't the first time that we've +wanted to include something in the JSON output but make it optional +for performance reasons. For example, show has a boolean --body +argument for this reason. What if this wasn't a new type of output, +but simply a new --ids=true (or --queries=true) argument?