From: Mark Walters Date: Sat, 11 Feb 2012 19:17:54 +0000 (+0000) Subject: Re: [Patch V4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=78d3de81ec5b9eba1b06c0ac66a15a28a1b01adc;p=notmuch-archives.git Re: [Patch V4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag --- diff --git a/d6/f3a82ac0ce9181589238203bc8a1efc4061993 b/d6/f3a82ac0ce9181589238203bc8a1efc4061993 new file mode 100644 index 000000000..7055510c3 --- /dev/null +++ b/d6/f3a82ac0ce9181589238203bc8a1efc4061993 @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 21F5E431FB6 + for ; Sat, 11 Feb 2012 11:16:42 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id wpQ2zuUgK8k1 for ; + Sat, 11 Feb 2012 11:16:41 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 79680429E45 + for ; Sat, 11 Feb 2012 11:16:41 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1RwIR2-0004Pu-9U; Sat, 11 Feb 2012 19:16:36 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1RwIR2-0001Yy-1N; Sat, 11 Feb 2012 19:16:36 +0000 +From: Mark Walters +To: notmuch@notmuchmail.org, Austin Clements , + Jameson Graef Rollins +Subject: Re: [Patch V4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag +In-Reply-To: <874nv9rv79.fsf@qmul.ac.uk> +References: <874nv9rv79.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.11.1+172~g6a5d2c5 (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Sat, 11 Feb 2012 19:17:54 +0000 +Message-ID: <87fwehi3h9.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: e0348628dcb1fd938051de16b468cf91 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 11 Feb 2012 19:16:42 -0000 + + +Hi + +> Here is the latest version of this patch set. I think I have fixed most +> of the problems raised in review but there are some remaining issues +> detailed below. + +I know this patch set needs rebasing on top of Jani's notmuch-show +command line parsing patch: should I do that now or wait for Jani's +patch to be accepted? + +But in response to id:"878vk943ci.fsf@servo.finestructure.net" I think +the first three patches which add the --no-exclude option (the three +patches are for the C code, the man pages and the tests) are self +contained so could go in without the rest of the series. They are much +smaller and simpler than the rest so should be relatively easy to +review, they seem to apply to current master and they are not affected +by Jani's patch as notmuch-show does not look at search_exclude_tags +currently. + +Best wishes + +Mark