From: Jani Nikula Date: Sat, 22 Dec 2012 21:48:04 +0000 (+0200) Subject: Re: [Patch v8 01/18] parse_tag_line: use enum for return value. X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=7789586f33710d4a3a968fa808578958891c673d;p=notmuch-archives.git Re: [Patch v8 01/18] parse_tag_line: use enum for return value. --- diff --git a/41/8a75ccb6d924bfd7309bf12d024f8387715d6b b/41/8a75ccb6d924bfd7309bf12d024f8387715d6b new file mode 100644 index 000000000..b87e57a54 --- /dev/null +++ b/41/8a75ccb6d924bfd7309bf12d024f8387715d6b @@ -0,0 +1,89 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A37A0431FAF + for ; Sat, 22 Dec 2012 13:48:10 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3m4PYjHoww4G for ; + Sat, 22 Dec 2012 13:48:10 -0800 (PST) +Received: from mail-la0-f54.google.com (mail-la0-f54.google.com + [209.85.215.54]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E6FE7431FAE + for ; Sat, 22 Dec 2012 13:48:09 -0800 (PST) +Received: by mail-la0-f54.google.com with SMTP id j13so7020771lah.13 + for ; Sat, 22 Dec 2012 13:48:08 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=x-received:from:to:cc:subject:in-reply-to:references:user-agent + :date:message-id:mime-version:content-type:x-gm-message-state; + bh=m61PjPgz92RfiDqV13kE7zV0/EWkd8je1D1k6YzcTGM=; + b=Jz/SiXepwQjg0E1ZVJuOkY7Grxq4XvjX7CRsuXicvUMjEZdLH/JCr5Uzfq2UHnCSbd + wSSC6JDjTpsbRMGhuHTjihRAPdfUhpZIVRVe78U7nXfKGnPHfPJ5yRJqjme0pYzhN77K + FHdms07A4C/OCu3y2/2PeXBpmgU8pPN0e6iC8cipD6YlRfLO4q+ZM3n6pXreA7XRE71R + aHKAwM4GZ1vD6dHHIzRVvVciiLa62cQbH0AHRVTqRfBaX671WlGsvCel4BBkpTW+L+qE + bnRMg7kH+kQZZXQu2pBRhQhBeZBIgerhXFlOIL/jAzVP0sPsfd68goukgI+UiYgcjWN8 + dMew== +X-Received: by 10.152.132.137 with SMTP id ou9mr16391350lab.7.1356212888331; + Sat, 22 Dec 2012 13:48:08 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-50df51-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id gr12sm6094110lab.3.2012.12.22.13.48.06 + (version=SSLv3 cipher=OTHER); Sat, 22 Dec 2012 13:48:07 -0800 (PST) +From: Jani Nikula +To: david@tethera.net, notmuch@notmuchmail.org +Subject: Re: [Patch v8 01/18] parse_tag_line: use enum for return value. +In-Reply-To: <1356095307-22895-1-git-send-email-david@tethera.net> +References: <1356095307-22895-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.14+211~gc8d6546 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Sat, 22 Dec 2012 23:48:04 +0200 +Message-ID: <87zk15hi7f.fsf@oiva.home.nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-Gm-Message-State: + ALoCoQnMj1DIziDAmpEIDyfHqeO61oaUgnk2y8JK9eMPLVuPnAMjaK5dj2+oHS2z6nRdWhGhp+yj +Cc: David Bremner +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 22 Dec 2012 21:48:10 -0000 + +On Fri, 21 Dec 2012, david@tethera.net wrote: +> From: David Bremner +> +> This is essentially cosmetic, since success=0 is promised by +> the comments in tag-utils.h. + +Squash this on top for completeness: + +diff --git a/tag-util.c b/tag-util.c +index 12aab08..17d7ac2 100644 +--- a/tag-util.c ++++ b/tag-util.c +@@ -47,7 +47,7 @@ parse_tag_line (void *ctx, char *line, + line_for_error = talloc_strdup (ctx, line); + if (line_for_error == NULL) { + fprintf (stderr, "Error: out of memory\n"); +- return -1; ++ return TAG_PARSE_OUT_OF_MEMORY; + } + + /* remove leading space */