From: Blake Jones Date: Thu, 15 Nov 2012 18:42:55 +0000 (+1600) Subject: Re: [PATCH v3 00/10] Solaris support X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=753e37b38e1b902b73ae2cf27760e7cf737831c1;p=notmuch-archives.git Re: [PATCH v3 00/10] Solaris support --- diff --git a/96/b8903f5106aa85a3049e633065c7939e3023bd b/96/b8903f5106aa85a3049e633065c7939e3023bd new file mode 100644 index 000000000..245332eb8 --- /dev/null +++ b/96/b8903f5106aa85a3049e633065c7939e3023bd @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C8A6F431FAF + for ; Thu, 15 Nov 2012 10:43:08 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id WgSEczSvrpzK for ; + Thu, 15 Nov 2012 10:43:05 -0800 (PST) +Received: from foo.net (70-36-235-136.dsl.static.sonic.net [70.36.235.136]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C8DC0431FAE + for ; Thu, 15 Nov 2012 10:43:04 -0800 (PST) +Received: from foo.net (localhost [127.0.0.1]) + by foo.net (8.14.5+Sun/8.14.5) with ESMTP id qAFIgtrF015994; + Thu, 15 Nov 2012 10:42:56 -0800 (PST) +To: Tomi Ollila +Subject: Re: [PATCH v3 00/10] Solaris support +In-Reply-To: Your message of "Thu, 15 Nov 2012 17:55:14 +0200." + +Date: Thu, 15 Nov 2012 10:42:55 -0800 +Message-ID: <15993.1353004975@foo.net> +From: Blake Jones +X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 + (foo.net [127.0.0.1]); Thu, 15 Nov 2012 10:42:57 -0800 (PST) +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 15 Nov 2012 18:43:08 -0000 + +> $ gcc compat/have_strsep.c +> compat/have_strsep.c: In function "main": +> compat/have_strsep.c:7:21: error: expected identifier or "(" before "const" +> compat/have_strsep.c:9:29: error: "delim" undeclared (first use in this function) +> compat/have_strsep.c:9:29: note: each undeclared identifier is reported only once for each function it appears in +> zsh: exit 1 gcc compat/have_strsep.c +> +> --- It is very easy to spot the problem ;) + +Sigh, yes it is. I started my Solaris port using some patches from +someone else who had done previous work on a Solaris port, and obviously +I didn't look at the patch very closely. In fact, after fixing +have_strsep.c, I saw that I didn't even need it -- Solaris 11 has +strsep() in libc. But I'd prefer to clean up this patch and leave the +compat version available for those compiling on older versions of +Solaris, if that's okay. + +> $ gcc compat/check_asctime.c +> compat/check_asctime.c: In function "main": +> compat/check_asctime.c:15:5: error: too many arguments to function "asctime_r" +> In file included from compat/check_asctime.c:8:0: +> /usr/include/time.h:266:14: note: declared here +> zsh: exit 1 gcc compat/check_asctime.c +> +> --- the posix-semantics way uses the 2-arg format. +> +> The logic of the test setting in this file doesn't open to +> me. Why not test the same way as in getpwuid_r() case ? + +Yeah, that's clearly the right thing to do. I was getting odd behavior +when I defined _POSIX_PTHREAD_SEMANTICS for getpwuid_r(), and it looks +like I fixed it in the wrong direction. + +Did you happen to notice any other issues besides these two? I'd rather +not spam the list with my ten-patch set if there's other silly stuff +that needs cleaning up. + +Thanks again for testing this. + +Blake