From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Fri, 1 Mar 2013 06:52:40 +0000 (+0200)
Subject: Re: [PATCH] cli: crypto: tell gmime to use gpg-agent
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=7317390073323b922a8092a97850d465c88c4423;p=notmuch-archives.git

Re: [PATCH] cli: crypto: tell gmime to use gpg-agent
---

diff --git a/75/312c51ea76b523f561409320558c687752ceaa b/75/312c51ea76b523f561409320558c687752ceaa
new file mode 100644
index 000000000..2f37f0fb1
--- /dev/null
+++ b/75/312c51ea76b523f561409320558c687752ceaa
@@ -0,0 +1,74 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 5CCC4431FBC
+	for <notmuch@notmuchmail.org>; Thu, 28 Feb 2013 22:52:55 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 1.207
+X-Spam-Level: *
+X-Spam-Status: No, score=1.207 tagged_above=-999 required=5
+	tests=[MISSING_HEADERS=1.207] autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id AwtYut8PS751 for <notmuch@notmuchmail.org>;
+	Thu, 28 Feb 2013 22:52:53 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id E6E26431FAF
+	for <notmuch@notmuchmail.org>; Thu, 28 Feb 2013 22:52:52 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id ECDEA100093
+	for <notmuch@notmuchmail.org>; Fri,  1 Mar 2013 08:52:40 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+Cc: notmuch@notmuchmail.org
+Subject: Re: [PATCH] cli: crypto: tell gmime to use gpg-agent
+In-Reply-To: <513046D9.8000102@fifthhorseman.net>
+References: <1361950838-22919-1-git-send-email-jani@nikula.org>
+	<87hakxpwcu.fsf@servo.finestructure.net>
+	<87r4k1znor.fsf@maritornes.cs.unb.ca>
+	<87ehg1pt2u.fsf@servo.finestructure.net>
+	<87txoxwf1a.fsf@nikula.org>
+	<87vc9cm12s.fsf@servo.finestructure.net>
+	<513046D9.8000102@fifthhorseman.net>
+User-Agent: Notmuch/0.15.2+45~g5d28a00 (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Fri, 01 Mar 2013 08:52:40 +0200
+Message-ID: <m27glrmx1j.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 01 Mar 2013 06:52:56 -0000
+
+On Fri, Mar 01 2013, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
+
+> On 02/28/2013 04:10 PM, Jameson Graef Rollins wrote:
+>> I think this point makes sense.  I guess my main worry was that querying
+>> the agent would have unintended consequences for someone who is not
+>> expecting it or specifically does not want it to be queried.  But maybe
+>> the point is that if they don't want that to happen, then they should
+>> just not call notmuch with --decrypt.  I suppose that's reasonable.
+>
+> I agree with this analysis.  automatically asking gmime to invoke the
+> agent is the right thing to do.
+>
+> 	--dkg
+
+4(5?) in favo(u)r, 0 against. dropped needs-review. Speak up if you disagree :D
+
+Tomi
+