From: Michal Sojka Date: Tue, 4 Sep 2012 16:29:02 +0000 (+0200) Subject: Re: [PATCH] emacs: Add customization group for replying X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=7156eca3d5c0a33506e3ec4c515e8ee1a9fd1e2b;p=notmuch-archives.git Re: [PATCH] emacs: Add customization group for replying --- diff --git a/50/b10e3c54d77bb522b4837d3687323eb6557535 b/50/b10e3c54d77bb522b4837d3687323eb6557535 new file mode 100644 index 000000000..0b85be7f3 --- /dev/null +++ b/50/b10e3c54d77bb522b4837d3687323eb6557535 @@ -0,0 +1,117 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 24378431FB6 + for ; Tue, 4 Sep 2012 09:29:13 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fgmQPuafrpMP for ; + Tue, 4 Sep 2012 09:29:12 -0700 (PDT) +Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) + by olra.theworths.org (Postfix) with ESMTP id 3DE61431FAF + for ; Tue, 4 Sep 2012 09:29:12 -0700 (PDT) +Received: from localhost (unknown [192.168.200.4]) + by max.feld.cvut.cz (Postfix) with ESMTP id 947BB19F332E; + Tue, 4 Sep 2012 18:29:07 +0200 (CEST) +X-Virus-Scanned: IMAP AMAVIS +Received: from max.feld.cvut.cz ([192.168.200.1]) + by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, + port 10044) + with ESMTP id 1XVKltS11Vn3; Tue, 4 Sep 2012 18:29:02 +0200 (CEST) +Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) + by max.feld.cvut.cz (Postfix) with ESMTP id 8703D19F3333; + Tue, 4 Sep 2012 18:29:02 +0200 (CEST) +Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30]) + (Authenticated sender: sojkam1) + by imap.feld.cvut.cz (Postfix) with ESMTPSA id 447D9660904; + Tue, 4 Sep 2012 18:29:02 +0200 (CEST) +Received: from wsh by steelpick.2x.cz with local (Exim 4.80) + (envelope-from ) + id 1T8vzq-0001KF-3P; Tue, 04 Sep 2012 18:29:02 +0200 +From: Michal Sojka +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Add customization group for replying +In-Reply-To: +References: <1343311113-22171-1-git-send-email-sojkam1@fel.cvut.cz> + <87vcfu2qap.fsf@steelpick.2x.cz> + +User-Agent: Notmuch/0.14+3~g608c52f (http://notmuchmail.org) Emacs/24.1.1 + (x86_64-pc-linux-gnu) +Date: Tue, 04 Sep 2012 18:29:02 +0200 +Message-ID: <87zk55n44x.fsf@steelpick.2x.cz> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Sep 2012 16:29:13 -0000 + +On Tue, Sep 04 2012, Tomi Ollila wrote: +> On Tue, Sep 04 2012, Michal Sojka wrote: +> +>> On Thu, Jul 26 2012, Michal Sojka wrote: +>>> When one wants to customize the format of reply message, there nothing +>>> to tell the user how to do it. Without knowing that construction of +>>> reply buffer is actually implemented in the message package, it seems +>>> that replying cannot be customized. +>>> +>>> Because I was getting annoyed by the empty line the between citation +>>> line and the quoted message, I figured out that changing this is fairly +>>> easy when one knows what to customize. +>>> +>>> This patch adds notmuch-reply customization group that that contains +>>> references to the relevant customization options. The new group is easy +>>> to find as it is shown as a result of running "M-x customize-group RET +>>> notmuch RET". +>> +>> Ping. +>> +>> Any objections against applying? +> +> Nobody dares to say anything due to infamiliriaty of this spesific case ;/. +> +> I could not find any reference this has been made before. + +It's at least documented at +http://www.gnu.org/software/emacs/manual/html_node/elisp/Group-Definitions.html + + The argument members is a list specifying an initial set of + customization items to be members of the group. However, most often + members is nil, and you specify the group's members by using the + :group keyword when defining those members. + +> I could not find any discussion about this issue. +> +> With little effort I could not extract the customization tree to +> stdout I could have attempted to grep whether there is same variable +> in many groups. + +I tried to grep emacs sources and found the following: + +(defgroup message '((user-mail-address custom-variable) +(defgroup gnus-message '((message custom-group)) +(defgroup ps-print-printer '((lpr custom-group)) +(defgroup customize '((widgets custom-group)) +(defgroup font-lock '((jit-lock custom-group)) + +At least the first line corresponds exactly to what is proposed in my +patch. + +Cheers, +-Michal