From: Austin Clements Date: Thu, 27 Dec 2012 23:04:02 +0000 (+1900) Subject: Re: [PATCH] emacs: tweak error buffer handling X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=6e334e5571c0e51a24aa591004268f20b817b034;p=notmuch-archives.git Re: [PATCH] emacs: tweak error buffer handling --- diff --git a/f6/c64c484c805d10fe0cfb3dfd1e0b093b274515 b/f6/c64c484c805d10fe0cfb3dfd1e0b093b274515 new file mode 100644 index 000000000..1e66dbbdc --- /dev/null +++ b/f6/c64c484c805d10fe0cfb3dfd1e0b093b274515 @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4FCC3431FB6 + for ; Thu, 27 Dec 2012 15:04:08 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id CyCx6TYErx+p for ; + Thu, 27 Dec 2012 15:04:07 -0800 (PST) +Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU + [18.7.68.37]) + by olra.theworths.org (Postfix) with ESMTP id 7BB19431FAF + for ; Thu, 27 Dec 2012 15:04:07 -0800 (PST) +X-AuditID: 12074425-b7ff26d000007f8d-d3-50dcd3e61ec1 +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP + id 0A.C7.32653.6E3DCD05; Thu, 27 Dec 2012 18:04:06 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id qBRN46SC020141; + Thu, 27 Dec 2012 18:04:06 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qBRN42Bx026687 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Thu, 27 Dec 2012 18:04:04 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1ToMUc-0001m5-OR; Thu, 27 Dec 2012 18:04:02 -0500 +Date: Thu, 27 Dec 2012 18:04:02 -0500 +From: Austin Clements +To: Mark Walters +Subject: Re: [PATCH] emacs: tweak error buffer handling +Message-ID: <20121227230402.GY6187@mit.edu> +References: <1356209345-11712-1-git-send-email-markwalters1009@gmail.com> + <87k3s4fnz8.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87k3s4fnz8.fsf@qmul.ac.uk> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42IRYrdT0X12+U6AwbSH1har5/JYXL85k9ni + zcp5rA7MHjtn3WX3OPx1IYvHs1W3mAOYo7hsUlJzMstSi/TtErgyZu78x1zwVKji9MHzjA2M + r/m6GDk5JARMJL6/OckEYYtJXLi3nq2LkYtDSGAfo8SUXbtYIJwNjBIPry5nhHAuMkmcbXzK + DOEsYZRo//uUtYuRg4NFQFXiyz8WkFFsAhoS2/aDNHByiAjoSNw+tIAdpIRZwFZi6pUYkLCw + gLnE7tObwUp4BbQlPh+fyg4xspdRYnb3XjaIhKDEyZlPwGYyC2hJ3Pj3kglijrTE8n8cIGFO + oFUvPlxgBrFFBVQkppzcxjaBUWgWku5ZSLpnIXQvYGRexSibklulm5uYmVOcmqxbnJyYl5da + pGuhl5tZopeaUrqJERzoLqo7GCccUjrEKMDBqMTDu6DnToAQa2JZcWXuIUZJDiYlUd4H54FC + fEn5KZUZicUZ8UWlOanFhxglOJiVRHi/xwPleFMSK6tSi/JhUtIcLErivDdSbvoLCaQnlqRm + p6YWpBbBZGU4OJQkeKsvATUKFqWmp1akZeaUIKSZODhBhvMADe8HqeEtLkjMLc5Mh8ifYlSU + EuedAJIQAElklObB9cIS0StGcaBXhHlXgVTxAJMYXPcroMFMQIOtecAGlyQipKQaGCXeaaRo + BQnIZ08OLHPfVFCw0tB464lTAj1/9twzFNpg4fzNsOo/0+eVu4sVy7y+rPqU5H9j9YuSo13M + 2xXvmmnUPJ46PaST58n2pM8LJ9w/PzUgeLnwCYMlxprPvlxizfux13ejsPyCLbOnFcuyL7xy + onjK69Wc+rtuqL7blmU/IdCDUZrlwS0lluKMREMt5qLiRAD0d5+rHwMAAA== +Cc: Tomi Ollila , notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 27 Dec 2012 23:04:08 -0000 + +Quoth Mark Walters on Dec 26 at 10:27 pm: +> +> On Tue, 25 Dec 2012, Tomi Ollila wrote: +> > On Sat, Dec 22 2012, Mark Walters wrote: +> > +> >> view-mode-enter changed between emacs 23 and emacs 24: the current +> >> code makes the error buffer disappear in emacs 24 on quitting it (ie +> >> pressing q) but this just kills the buffer without closing the split +> >> window in emacs 23. +> >> +> >> This patch makes the error buffer window disappear in emacs 23 +> >> too. Since the view-mode-enter function changed we have to test for +> >> version and do the correct thing in each case. +> >> --- +> >> +> >> This seems to work but I have only tested on 23.4 and 24.2 +> > +> > I run emacs 23.1.1 to get the documentation of view-mode-enter +> > there. So, this patch instructs to delete WINDOW when exiting +> > view mode... +> > +> > Documentation of pop-to-buffer says: +> > +> > "Select buffer BUFFER-OR-NAME in some window, preferably a different one." +> > +> > What if pop-up-windows's value is nil -- the content of current window +> > is replaced with this view stuff -- and when exiting view mode, the +> > window will be deleted ? What happens with emacs 24 in this case ? +> +> Hi +> +> You are quite right there are problems here under emacs 23: if you +> already have a split window when the error occurs in one part the error +> is displayed in the other window and then on exit that (previously +> existing) window is closed. +> +> What do people think should happen on an error? I, personally, don't +> like taking over an existing window, and Jamie liked some of the errors +> (eg non-fatal `locked database' tagging errors) to be shown in the +> mini-buffer. +> +> I also think it is going to be difficult to get this right: emacs 23 and +> 24 are different and there are also some user configuration variable +> that affect what happens. + +How about showing all errors in the minibuffer (which could simply +mean calling (error ...) and letting the Emacs top-level show it in +the mini-buffer)? We could log the verbose error details (like +stdout) to some other buffer that we don't automatically show, but +instead simply reference from the minibuffer message. This would be +more in line with how Emacs typically handles errors, and would make +the details available to the user without flooding them with the +details.