From: Austin Clements Date: Wed, 31 Oct 2012 03:17:25 +0000 (+2000) Subject: Re: [PATCH v6 0/9] notmuch search date:since..until query support X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=66894a11a291dc65232e745dc66e6112cc70c559;p=notmuch-archives.git Re: [PATCH v6 0/9] notmuch search date:since..until query support --- diff --git a/ca/ee2110c2c4b375608ef7d949dac5ef03e51fae b/ca/ee2110c2c4b375608ef7d949dac5ef03e51fae new file mode 100644 index 000000000..4b5e837b4 --- /dev/null +++ b/ca/ee2110c2c4b375608ef7d949dac5ef03e51fae @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 943E6431FBD + for ; Tue, 30 Oct 2012 20:17:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id t6YpXNhZSWIm for ; + Tue, 30 Oct 2012 20:17:28 -0700 (PDT) +Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU + [18.7.68.35]) + by olra.theworths.org (Postfix) with ESMTP id 27B42431FBC + for ; Tue, 30 Oct 2012 20:17:28 -0700 (PDT) +X-AuditID: 12074423-b7fab6d0000008f9-c6-50909847ccf1 +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP + id A4.07.02297.74890905; Tue, 30 Oct 2012 23:17:27 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q9V3HRqI007987; + Tue, 30 Oct 2012 23:17:27 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q9V3HPME013400 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Tue, 30 Oct 2012 23:17:27 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1TTOo1-0001iI-Mk; Tue, 30 Oct 2012 23:17:25 -0400 +Date: Tue, 30 Oct 2012 23:17:25 -0400 +From: Austin Clements +To: Jani Nikula +Subject: Re: [PATCH v6 0/9] notmuch search date:since..until query support +Message-ID: <20121031031725.GL15377@mit.edu> +References: +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT13WfMSHA4N5yPYum6c4W12/OZHZg + 8rh1/zW7x7NVt5gDmKK4bFJSczLLUov07RK4Mg7fv85ccJu9oq9/EWMD41S2LkYODgkBE4lP + ExS7GDmBTDGJC/fWs4HYQgL7GCUedzN2MXIB2RsYJZo2nWWDcE4ySZzaswQqs4RR4sOU1ewg + LSwCqhI7v65kAbHZBDQktu1fzghiiwgoSmw+uR/MZhaQlvj2u5kJxBYW8JJY+WcRWD2vgI7E + 15kNjBCrjST2tTxghogLSpyc+YQFoldL4sa/l0wgV4PMWf6PAyTMKWAsMXXxYVYQW1RARWLK + yW1sExiFZiHpnoWkexZC9wJG5lWMsim5Vbq5iZk5xanJusXJiXl5qUW6Znq5mSV6qSmlmxjB + Ie2ivIPxz0GlQ4wCHIxKPLya3/sDhFgTy4orcw8xSnIwKYnyik6bECDEl5SfUpmRWJwRX1Sa + k1p8iFGCg1lJhPdiBlCONyWxsiq1KB8mJc3BoiTOey3lpr+QQHpiSWp2ampBahFMVoaDQ0mC + 12A6UKNgUWp6akVaZk4JQpqJgxNkOA/Q8BUgNbzFBYm5xZnpEPlTjIpS4rxRIAkBkERGaR5c + LyzlvGIUB3pFmDcepIoHmK7gul8BDWYCGqzD1wsyuCQRISXVwLj3SFv5szpJQ6EKJvNrYStX + rVzEe9x08nmRuAMpy+fV3X/i8aTits495ceXzbOdwv+d2vP1hEj0AoPExDe6dVd5wn8ufpLm + erpt/t7sN8uOzWbzrWfRZXm+9Nw27YVNrlWr9yY5rr4l6+pnalu7+HKOgceNr+7vVRwubdq6 + o2WTemOeFtNp+4tKLMUZiYZazEXFiQB9I9cjFAMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 31 Oct 2012 03:17:28 -0000 + +LGTM. + +Quoth Jani Nikula on Oct 30 at 10:32 pm: +> Hi all, v6 of [1] with plenty of small changes addressing Austin's +> review [2], [3], [4], and [5]. See my replies to Austin for what I've +> agreed to change, and what I've chosen to ignore and why. +> +> The single biggest change is the requirement to have some delimiter(s) +> between keywords, which allowed simplification of keyword +> matching. Consequently match_keyword() and parse_keyword() functions in +> patch 2/9 have changed considerably. +> +> There are a few ways to examine the changes since v5. My public repo at +> [6] has branches topic-parse-time-string-v5 (rebased to master) and +> topic-parse-time-string-v6, and [7] should provide a fancy colorful diff +> between the two. The same but less fancy diff is also at the end of this +> cover letter. +> +> Change by change commits to the parser and test tool can also be found +> at [8]. The source files there are copied verbatim to patches 2/9 and +> 3/9.