From: Tom Yu <tlyu@mit.edu>
Date: Tue, 29 Sep 2009 01:12:36 +0000 (+0000)
Subject: pull up r22474 from trunk
X-Git-Tag: krb5-1.7.1-beta1~30
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=654c2e5f4f3f0b121b826d4bb11a236280103960;p=krb5.git

pull up r22474 from trunk

 ------------------------------------------------------------------------
 r22474 | epeisach | 2009-07-30 13:22:28 -0400 (Thu, 30 Jul 2009) | 7 lines

 ticket: 6541
 subject: Fix memory leak in k5_pac_verify_server_checksum

 k5_pac_verify_server_checksum was leaking memory when the checksum was valid.

 t_pac.c: Fix memory leak by forgetting to release memory.

ticket: 6541
version_fixed: 1.7.1
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22809 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/krb5/krb/pac.c b/src/lib/krb5/krb/pac.c
index 30a63bf35..c5a706562 100644
--- a/src/lib/krb5/krb/pac.c
+++ b/src/lib/krb5/krb/pac.c
@@ -547,8 +547,10 @@ k5_pac_verify_server_checksum(krb5_context context,
 
     ret = krb5_c_verify_checksum(context, server, KRB5_KEYUSAGE_APP_DATA_CKSUM,
 				 &pac_data, &checksum, &valid);
+
+    free(pac_data.data);
+
     if (ret != 0) {
-	free(pac_data.data);
 	return ret;
     }
 
diff --git a/src/lib/krb5/krb/t_pac.c b/src/lib/krb5/krb/t_pac.c
index 527e3db22..503d778a9 100644
--- a/src/lib/krb5/krb/t_pac.c
+++ b/src/lib/krb5/krb/t_pac.c
@@ -220,6 +220,8 @@ main(int argc, char **argv)
         if (ret)
             err(context, ret, "krb5_pac_verify 4");
         
+        krb5_free_data_contents(context, &data);
+
         krb5_pac_free(context, pac2);
     }