From: Michal Sojka Date: Thu, 6 Sep 2012 08:10:28 +0000 (+0200) Subject: Re: [PATCH] emacs: Add customization group for replying X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=64cbb3fd081257edd1e209420c0fd7f22299bfe6;p=notmuch-archives.git Re: [PATCH] emacs: Add customization group for replying --- diff --git a/ef/f13d1599da64722a1dde99740fa69e2b980b3b b/ef/f13d1599da64722a1dde99740fa69e2b980b3b new file mode 100644 index 000000000..75e6af00b --- /dev/null +++ b/ef/f13d1599da64722a1dde99740fa69e2b980b3b @@ -0,0 +1,140 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A9B25431FB6 + for ; Thu, 6 Sep 2012 01:10:40 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 0uuYcYDlzgig for ; + Thu, 6 Sep 2012 01:10:39 -0700 (PDT) +Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) + by olra.theworths.org (Postfix) with ESMTP id 8CE08431FAE + for ; Thu, 6 Sep 2012 01:10:39 -0700 (PDT) +Received: from localhost (unknown [192.168.200.4]) + by max.feld.cvut.cz (Postfix) with ESMTP id 1812E19F32ED; + Thu, 6 Sep 2012 10:10:34 +0200 (CEST) +X-Virus-Scanned: IMAP AMAVIS +Received: from max.feld.cvut.cz ([192.168.200.1]) + by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, + port 10044) + with ESMTP id dVHkoaQ-aWoZ; Thu, 6 Sep 2012 10:10:29 +0200 (CEST) +Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) + by max.feld.cvut.cz (Postfix) with ESMTP id 0A14C3CFE74; + Thu, 6 Sep 2012 10:10:28 +0200 (CEST) +Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30]) + (Authenticated sender: sojkam1) + by imap.feld.cvut.cz (Postfix) with ESMTPSA id BB439660904; + Thu, 6 Sep 2012 10:10:28 +0200 (CEST) +Received: from wsh by steelpick.2x.cz with local (Exim 4.80) + (envelope-from ) + id 1T9XAS-0004l7-JO; Thu, 06 Sep 2012 10:10:28 +0200 +From: Michal Sojka +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Add customization group for replying +In-Reply-To: +References: <1343311113-22171-1-git-send-email-sojkam1@fel.cvut.cz> + <87vcfu2qap.fsf@steelpick.2x.cz> + + <87zk55n44x.fsf@steelpick.2x.cz> + +User-Agent: Notmuch/0.14+23~g9d68aca (http://notmuchmail.org) Emacs/24.1.1 + (x86_64-pc-linux-gnu) +Date: Thu, 06 Sep 2012 10:10:28 +0200 +Message-ID: <874nnbvaff.fsf@steelpick.2x.cz> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 06 Sep 2012 08:10:40 -0000 + +On Wed, Sep 05 2012, Tomi Ollila wrote: +> On Tue, Sep 04 2012, Michal Sojka wrote: +> +>> On Tue, Sep 04 2012, Tomi Ollila wrote: +>>> On Tue, Sep 04 2012, Michal Sojka wrote: +>>> +>>>> On Thu, Jul 26 2012, Michal Sojka wrote: +>>>>> When one wants to customize the format of reply message, there nothing +>>>>> to tell the user how to do it. Without knowing that construction of +>>>>> reply buffer is actually implemented in the message package, it seems +>>>>> that replying cannot be customized. +>>>>> +>>>>> Because I was getting annoyed by the empty line the between citation +>>>>> line and the quoted message, I figured out that changing this is fairly +>>>>> easy when one knows what to customize. +>>>>> +>>>>> This patch adds notmuch-reply customization group that that contains +>>>>> references to the relevant customization options. The new group is easy +>>>>> to find as it is shown as a result of running "M-x customize-group RET +>>>>> notmuch RET". +>>>> +>>>> Ping. +>>>> +>>>> Any objections against applying? +>>> +>>> Nobody dares to say anything due to infamiliriaty of this spesific case ;/. +>>> +>>> I could not find any reference this has been made before. +>> +>> It's at least documented at +>> http://www.gnu.org/software/emacs/manual/html_node/elisp/Group-Definitions.html +>> +>> The argument members is a list specifying an initial set of +>> customization items to be members of the group. However, most often +>> members is nil, and you specify the group's members by using the +>> :group keyword when defining those members. +>> +>>> I could not find any discussion about this issue. +>>> +>>> With little effort I could not extract the customization tree to +>>> stdout I could have attempted to grep whether there is same variable +>>> in many groups. +>> +>> I tried to grep emacs sources and found the following: +>> +>> (defgroup message '((user-mail-address custom-variable) +>> (defgroup gnus-message '((message custom-group)) +>> (defgroup ps-print-printer '((lpr custom-group)) +>> (defgroup customize '((widgets custom-group)) +>> (defgroup font-lock '((jit-lock custom-group)) +>> +>> At least the first line corresponds exactly to what is proposed in my +>> patch. +> +> Yes... +> +> +> I was looking whether the same customization variable has been put +> into multiple groups (now those are also in message-insertion group like +> you have in your patch). (So far) I haven't seen that to be done +> (not that it forbids doing so, just that there aren't issues about that). +> +> From consistency point of view all the customization variables in notmuch +> groups start with "notmuch-" and these "message-" breaks this... An +> alternative to the above could be the following: +> +> (defgroup notmuch-reply +> '((notmuch-message-replied-tags custom-variable) +> (message-insertion custom-group)) +> "..." + +Why not. Updated patch follows... + +-Michal