From: david Date: Sat, 24 Nov 2012 21:20:00 +0000 (+2000) Subject: V2 of batch-tagging plus new dump/restore X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=629ad4208f234c5249f9a0f4957611dfc7811b71;p=notmuch-archives.git V2 of batch-tagging plus new dump/restore --- diff --git a/5c/ef6ceaa493c2586f3f54fec63fb509d4d30429 b/5c/ef6ceaa493c2586f3f54fec63fb509d4d30429 new file mode 100644 index 000000000..b17dfb10d --- /dev/null +++ b/5c/ef6ceaa493c2586f3f54fec63fb509d4d30429 @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 898E8431FAF + for ; Sat, 24 Nov 2012 13:20:31 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UDyDUe9GLrje for ; + Sat, 24 Nov 2012 13:20:31 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2119B431FAE + for ; Sat, 24 Nov 2012 13:20:31 -0800 (PST) +Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.89.108] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) id 1TcN9H-0006SG-1M + for notmuch@notmuchmail.org; Sat, 24 Nov 2012 17:20:27 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) id 1TcN9B-0008CJ-75 + for notmuch@notmuchmail.org; Sat, 24 Nov 2012 17:20:21 -0400 +From: david@tethera.net +To: notmuch@notmuchmail.org +Subject: V2 of batch-tagging plus new dump/restore +Date: Sat, 24 Nov 2012 17:20:00 -0400 +Message-Id: <1353792017-31459-1-git-send-email-david@tethera.net> +X-Mailer: git-send-email 1.7.10.4 +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 24 Nov 2012 21:20:31 -0000 + +this obsoletes: id:1353265498-3839-1-git-send-email-david@tethera.net + +Changes based on Mark's review + +- add commments for each function in tag-util.h + +- inline tag_op_list_from_string in the one place it was called + +- remove NULL terminator from tag_op_list (for mark); along with + tag_op_list_t being opaque, I thought is was ok to leave off the + comment on ops. But I could be convinced. + +- make tag_op_list_t typedef opaque + +- add BE_GENEROUS flag to parser. Currently this enables empty tags. + +- handle blank lines and comments in restore and batch tagging + +- fixed the commit message about "notmuch-new" + +Changes based on Ethan's review: + +- remove the dreaded . from first line of commit messages + +- convert if on l49 of database-test.c into explicit return on error + +- add comments and parens for num_tags and this_mid_len in random_corpus.c + +- add check for message-id's less than length 1. I wasn't sure why we + would disallow all message ids of length 1. + +- remove declaration of parse_tag_stream + +- explain "query_string += 3" + +- fix typo in notmuch-dump.1 +