From: Jameson Graef Rollins Date: Fri, 4 Jan 2013 05:32:16 +0000 (+1600) Subject: Re: Xapian-quoting based batch-tagging. X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=625df62d4611a9657996c04eb2a1b839dd064174;p=notmuch-archives.git Re: Xapian-quoting based batch-tagging. --- diff --git a/3e/d97718089fcec2ed04df82e9e658844ca0486f b/3e/d97718089fcec2ed04df82e9e658844ca0486f new file mode 100644 index 000000000..0686572e5 --- /dev/null +++ b/3e/d97718089fcec2ed04df82e9e658844ca0486f @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1E408431FAF + for ; Thu, 3 Jan 2013 21:32:27 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UcIyDS8WVFgc for ; + Thu, 3 Jan 2013 21:32:25 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 4A59A431FAE + for ; Thu, 3 Jan 2013 21:32:25 -0800 (PST) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 9CAB766E0135; + Thu, 3 Jan 2013 21:32:24 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (h-67-101-209-224.snfccasy.dynamic.covad.net + [67.101.209.224]) (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id B264C66E00E7; + Thu, 3 Jan 2013 21:32:19 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id D4BE861702; Thu, 3 Jan 2013 21:32:18 -0800 (PST) +From: Jameson Graef Rollins +To: Jani Nikula , David Bremner , + Mark Walters , notmuch@notmuchmail.org +Subject: Re: Xapian-quoting based batch-tagging. +In-Reply-To: <87mwwqgil3.fsf@nikula.org> +References: <1356464567-21779-1-git-send-email-david@tethera.net> + <87ehid5h64.fsf@qmul.ac.uk> <87txr9q763.fsf@zancas.localnet> + <87mwwqgil3.fsf@nikula.org> +User-Agent: Notmuch/0.14+233~gbbb15ec (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Thu, 03 Jan 2013 21:32:16 -0800 +Message-ID: <87mwwpo6n3.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 04 Jan 2013 05:32:27 -0000 + +--=-=-= +Content-Type: text/plain + +On Thu, Jan 03 2013, Jani Nikula wrote: +>>> I am unclear about how this is going to deal with queries containing +>>> newlines. For dump/restore I think this is not a problem (as Austin and +>>> others have said), but for batch tagging I think it could be; for +>>> example the query could be for a tag containing a newline. +>> +>> Yes, that's true, this patch series does not support queries with tags +>> with embedded newlines. They can still be removed (and added) via either +>> batch tagging or the command line. We could just live with this, or +> +> I think we should just live with it. It's a bunch of code with some UI +> wrinkles for a marginal feature. + +Tags with newlines are psychotic. We should just explicitly forbid them +by preventing them from ever being applied and then never have to worry +about them again. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJQ5mlgAAoJEO00zqvie6q8Ee8QAJmD92eDBau6VUJRCG8UUrv7 +jAtin734TrYryCr8xQQewKZyKBr7pAJvtDBGZoGYNSBkH7bhi9Lmi2dvliSmoBlx +1+a8WwfOm/HQgCwxlqFMusda45Gl3B/xuhC+D0qTX00zKtdDHZNe3Cy49GwXkaCh +NVVs+1QiEhdkgPVnhaRPbIGvSev33KSdk/MDVvvIfsAQyUzkGSGwmeEqjftJiSSA +cR4GONAPUO7Jo3APDH3QmK5nxkVKF+vRzK4zUoeyROqryZ5p04wDaERWpJ/G551u +YEAI5Ed3DuhetF1GOxh3AfDbgy3SOQ1XvnapRg+qONrq6kXmPXpSiB16OC/DtI63 +3e18lYqGlCqkkMLyLexcd5/aDzc5vc3k4g+vXc+1enfurFfjql3wFACPH0OAehvF +dhXhGJq/wOmB+nnpfHTpxv+hlaLt3mdBBPP5TpK7r2SAR2t84GlJicjyv2LpPclO +mfKRjrARPOzw4Yw9B1hMsvNsw1tV02zziGfcDCiILmsXJY8f9SPD3h3pWsM48Jk0 +14Lqnfc92Cozw4N0UEjgdfnjpaRhjIN5blc1ZJ8D6C3ExzpnatDPfbhPIpfDdHr9 +ju7hXmfE/jVOw6iA+rNjZldnUgnbjPxUFkRNJxNyblBYpj+qRiw8lsyX83fNLS61 +cx5l1fQ4Mq5sAAphKupo +=c8lx +-----END PGP SIGNATURE----- +--=-=-=--