From: Peter Wang Date: Mon, 19 Nov 2012 12:34:35 +0000 (+1100) Subject: Re: [PATCH 01/18] cli: add stub for insert command X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=5f8c976ae5b192859545a717f5148e335bc6bebe;p=notmuch-archives.git Re: [PATCH 01/18] cli: add stub for insert command --- diff --git a/cb/12e5aeba3ce7b471931bdcab8856c0a94fb25d b/cb/12e5aeba3ce7b471931bdcab8856c0a94fb25d new file mode 100644 index 000000000..2e3a27cc2 --- /dev/null +++ b/cb/12e5aeba3ce7b471931bdcab8856c0a94fb25d @@ -0,0 +1,95 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 59D94431FBF + for ; Mon, 19 Nov 2012 04:34:42 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id lF1vdQocbi6F for ; + Mon, 19 Nov 2012 04:34:41 -0800 (PST) +Received: from mail-da0-f53.google.com (mail-da0-f53.google.com + [209.85.210.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id BD18E431FBC + for ; Mon, 19 Nov 2012 04:34:41 -0800 (PST) +Received: by mail-da0-f53.google.com with SMTP id g9so2709805dad.26 + for ; Mon, 19 Nov 2012 04:34:41 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=date:message-id:from:to:cc:subject:in-reply-to:references + :mime-version:content-type:content-disposition + :content-transfer-encoding; + bh=rXS0kAfS3iC3L6tE2VtxJoY2Rflx6BdOW8tV2BXNQxQ=; + b=q9O0PwlHShWB3MvMQpokskQ87EQxAllX6HMoR6Jjn/rGeMnl0e3RGRX06EcR0iadSJ + D/nXDpXBgFyzaWfn32fpNojoF1+96w7KeARePHCj5xFOKFg2lcSHxj77iqMDVnsW2Rmf + jUuEKcaY9f9xK3h1mKFvjpf/NNzE2G1vcHBEnQ3+Qj2DcYuEC7z0m0NdCFgAF0uZAEsj + sCV+Upz0ZkRj42j8rOfS9H2faCQrlKgfgxpIloQQJ7WaQsvqCZc+H4JshCdYFPBNAbZb + RLuIQpELn0+f+dfdo9HoNwX+OD0wJhZBcMBl6n64IaSjuEKTDaS6JU/QFIrCp+oALmgU + Xpqg== +Received: by 10.68.230.105 with SMTP id sx9mr38701368pbc.44.1353328481064; + Mon, 19 Nov 2012 04:34:41 -0800 (PST) +Received: from localhost (215.42.233.220.static.exetel.com.au. + [220.233.42.215]) + by mx.google.com with ESMTPS id e9sm6127081paz.28.2012.11.19.04.34.38 + (version=TLSv1/SSLv3 cipher=OTHER); + Mon, 19 Nov 2012 04:34:39 -0800 (PST) +Date: Mon, 19 Nov 2012 23:34:35 +1100 +Message-ID: <20121119233435.GD2063@hili.localdomain> +From: Peter Wang +To: Mark Walters +Subject: Re: [PATCH 01/18] cli: add stub for insert command +In-Reply-To: <87fw46q0f7.fsf@qmul.ac.uk> +References: <1343223767-9812-1-git-send-email-novalazy@gmail.com> + <87fw46q0f7.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: 8bit +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 19 Nov 2012 12:34:42 -0000 + +On Sun, 18 Nov 2012 17:35:23 +0000, Mark Walters wrote: +> +> Hi +> +> I have now been through essentially the whole series (except the tests) +> and broadly like it. Just to summarise my concerns from the individual +> replies here: + +Thanks for the review. + +> +> What should insert do when interrupted and is it safe? I am not +> knowledgeable enough to be confident about that. + +Do you mean cleaning up stray files? Otherwise I think we just return +an error code, and then it's the caller's responsibility. + +> +> I think some of the talloc allocations need their return values +> checked. I am more worried about this here then in most of the rest of +> notmuch as we are writing to the database (and even to the mailstore +> itself). + +Will do. + +Peter