From: David Bremner Date: Tue, 9 Apr 2013 11:50:09 +0000 (+2100) Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=5c80820e76760497c1e686f9255351a68e2c90bc;p=notmuch-archives.git Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. --- diff --git a/cc/94934c2a042ec3b260b82637cdcc5ea39f9331 b/cc/94934c2a042ec3b260b82637cdcc5ea39f9331 new file mode 100644 index 000000000..f5ca5c429 --- /dev/null +++ b/cc/94934c2a042ec3b260b82637cdcc5ea39f9331 @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E2D90431FBD + for ; Tue, 9 Apr 2013 04:50:24 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XOKiiiQExxYp for ; + Tue, 9 Apr 2013 04:50:24 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 19399431FAE + for ; Tue, 9 Apr 2013 04:50:24 -0700 (PDT) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1UPX43-0001Cx-KY; Tue, 09 Apr 2013 08:50:16 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1UPX3x-0007wy-Q6; Tue, 09 Apr 2013 08:50:09 -0300 +From: David Bremner +To: Tomi Ollila , Jed Brown , + Jani Nikula , Karl Fogel , + Daniel Bergey +Subject: Re: [PATCH] emacs: add missing paren to fix defun in + notmuch-address.el. +In-Reply-To: +References: <87wqsfik5l.fsf@floss.red-bean.com> + <87mwtah2hd.fsf@zancas.localnet> + <877gkeau42.fsf@floss.red-bean.com> + <8738v1jtzc.fsf@nikula.org> + <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov> + +User-Agent: Notmuch/0.15.2+73~g1c450ec (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Tue, 09 Apr 2013 08:50:09 -0300 +Message-ID: <87vc7vgbym.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 09 Apr 2013 11:50:25 -0000 + +Tomi Ollila writes: + +> On Tue, Apr 09 2013, Jed Brown wrote: +> +>> David Bremner writes: +>> +>>> Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to +>>> do it myself. +>> +>> I tested the attached and it's working as expected. Sent as an +>> attachment to preserve author information. +> +> LGTM (this time tested, too). Also compared diffs by hand, change as announced. +> comments in id:m26207wgyt.fsf@guru.guru-group.fi (amend!) apply. + +There seems to be a few warnings: + +In notmuch-bbdb/snarf-from: +notmuch-address.el:116:26:Warning: reference to free variable + `bbdb-get-addresses-headers' + +In notmuch-bbdb/snarf-to: +notmuch-address.el:122:29:Warning: reference to free variable + `bbdb-get-addresses-headers' + +In end of data: +notmuch-address.el:143:1:Warning: the following functions are not known to be + defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header + +Do we need a few defvars? + +d