From: Adam Wolfe Gordon Date: Wed, 22 Feb 2012 06:46:31 +0000 (+1700) Subject: [PATCH v6 02/10] reply: Factor out reply creation X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=5b993c7ab87d99c4a5040f11422a9978cbe37e0e;p=notmuch-archives.git [PATCH v6 02/10] reply: Factor out reply creation --- diff --git a/11/17c2470c9a91641a0c89b3ae66a8f81d9e188e b/11/17c2470c9a91641a0c89b3ae66a8f81d9e188e new file mode 100644 index 000000000..ae9d80ad3 --- /dev/null +++ b/11/17c2470c9a91641a0c89b3ae66a8f81d9e188e @@ -0,0 +1,189 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B52B5431FAE + for ; Tue, 21 Feb 2012 22:46:46 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OpC9sZWhhMbI for ; + Tue, 21 Feb 2012 22:46:45 -0800 (PST) +Received: from idcmail-mo1so.shaw.ca (idcmail-mo1so.shaw.ca [24.71.223.10]) + by olra.theworths.org (Postfix) with ESMTP id CBB81431FB6 + for ; Tue, 21 Feb 2012 22:46:45 -0800 (PST) +Received: from pd2ml3so-ssvc.prod.shaw.ca ([10.0.141.148]) + by pd4mo1so-svcs.prod.shaw.ca with ESMTP; 21 Feb 2012 23:46:43 -0700 +X-Cloudmark-SP-Filtered: true +X-Cloudmark-SP-Result: v=1.1 cv=W+ZrOcpwHTeQLvZQ9vbIxXRdvbK5p6H2/T6SuQCN924= + c=1 sm=1 + a=VOVZfvsCZTcA:10 a=BLceEmwcHowA:10 a=yQp6g8lIsgqumF79BAsFDg==:17 + a=Ip1p9aMYQwLSyBp_cu4A:9 a=kK51L1ATiIlFzoh5DWsA:7 + a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 +Received: from unknown (HELO lagos.xvx.ca) ([96.52.216.56]) + by pd2ml3so-dmz.prod.shaw.ca with ESMTP; 21 Feb 2012 23:46:45 -0700 +Received: by lagos.xvx.ca (Postfix, from userid 1000) + id 8A4818004ED6; Tue, 21 Feb 2012 23:46:44 -0700 (MST) +From: Adam Wolfe Gordon +To: notmuch@notmuchmail.org +Subject: [PATCH v6 02/10] reply: Factor out reply creation +Date: Tue, 21 Feb 2012 23:46:31 -0700 +Message-Id: <1329893199-21630-3-git-send-email-awg+notmuch@xvx.ca> +X-Mailer: git-send-email 1.7.5.4 +In-Reply-To: <1329893199-21630-1-git-send-email-awg+notmuch@xvx.ca> +References: <1329893199-21630-1-git-send-email-awg+notmuch@xvx.ca> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 22 Feb 2012 06:46:47 -0000 + +Factor out the creation of a reply message based on an original +message so it can be shared by different reply formats. +--- + notmuch-reply.c | 101 +++++++++++++++++++++++++++++++----------------------- + 1 files changed, 58 insertions(+), 43 deletions(-) + +diff --git a/notmuch-reply.c b/notmuch-reply.c +index 6b244e6..8e56245 100644 +--- a/notmuch-reply.c ++++ b/notmuch-reply.c +@@ -505,6 +505,61 @@ guess_from_received_header (notmuch_config_t *config, notmuch_message_t *message + return NULL; + } + ++static GMimeMessage * ++create_reply_message(void *ctx, ++ notmuch_config_t *config, ++ notmuch_message_t *message, ++ notmuch_bool_t reply_all) ++{ ++ const char *subject, *from_addr = NULL; ++ const char *in_reply_to, *orig_references, *references; ++ ++ /* The 1 means we want headers in a "pretty" order. */ ++ GMimeMessage *reply = g_mime_message_new (1); ++ if (reply == NULL) { ++ fprintf (stderr, "Out of memory\n"); ++ return NULL; ++ } ++ ++ subject = notmuch_message_get_header (message, "subject"); ++ if (subject) { ++ if (strncasecmp (subject, "Re:", 3)) ++ subject = talloc_asprintf (ctx, "Re: %s", subject); ++ g_mime_message_set_subject (reply, subject); ++ } ++ ++ from_addr = add_recipients_from_message (reply, config, ++ message, reply_all); ++ ++ if (from_addr == NULL) ++ from_addr = guess_from_received_header (config, message); ++ ++ if (from_addr == NULL) ++ from_addr = notmuch_config_get_user_primary_email (config); ++ ++ from_addr = talloc_asprintf (ctx, "%s <%s>", ++ notmuch_config_get_user_name (config), ++ from_addr); ++ g_mime_object_set_header (GMIME_OBJECT (reply), ++ "From", from_addr); ++ ++ in_reply_to = talloc_asprintf (ctx, "<%s>", ++ notmuch_message_get_message_id (message)); ++ ++ g_mime_object_set_header (GMIME_OBJECT (reply), ++ "In-Reply-To", in_reply_to); ++ ++ orig_references = notmuch_message_get_header (message, "references"); ++ references = talloc_asprintf (ctx, "%s%s%s", ++ orig_references ? orig_references : "", ++ orig_references ? " " : "", ++ in_reply_to); ++ g_mime_object_set_header (GMIME_OBJECT (reply), ++ "References", references); ++ ++ return reply; ++} ++ + static int + notmuch_reply_format_default(void *ctx, + notmuch_config_t *config, +@@ -515,8 +570,6 @@ notmuch_reply_format_default(void *ctx, + GMimeMessage *reply; + notmuch_messages_t *messages; + notmuch_message_t *message; +- const char *subject, *from_addr = NULL; +- const char *in_reply_to, *orig_references, *references; + const notmuch_show_format_t *format = &format_reply; + + for (messages = notmuch_query_search_messages (query); +@@ -525,48 +578,10 @@ notmuch_reply_format_default(void *ctx, + { + message = notmuch_messages_get (messages); + +- /* The 1 means we want headers in a "pretty" order. */ +- reply = g_mime_message_new (1); +- if (reply == NULL) { +- fprintf (stderr, "Out of memory\n"); +- return 1; +- } +- +- subject = notmuch_message_get_header (message, "subject"); +- if (subject) { +- if (strncasecmp (subject, "Re:", 3)) +- subject = talloc_asprintf (ctx, "Re: %s", subject); +- g_mime_message_set_subject (reply, subject); +- } +- +- from_addr = add_recipients_from_message (reply, config, message, +- reply_all); ++ reply = create_reply_message (ctx, config, message, reply_all); + +- if (from_addr == NULL) +- from_addr = guess_from_received_header (config, message); +- +- if (from_addr == NULL) +- from_addr = notmuch_config_get_user_primary_email (config); +- +- from_addr = talloc_asprintf (ctx, "%s <%s>", +- notmuch_config_get_user_name (config), +- from_addr); +- g_mime_object_set_header (GMIME_OBJECT (reply), +- "From", from_addr); +- +- in_reply_to = talloc_asprintf (ctx, "<%s>", +- notmuch_message_get_message_id (message)); +- +- g_mime_object_set_header (GMIME_OBJECT (reply), +- "In-Reply-To", in_reply_to); +- +- orig_references = notmuch_message_get_header (message, "references"); +- references = talloc_asprintf (ctx, "%s%s%s", +- orig_references ? orig_references : "", +- orig_references ? " " : "", +- in_reply_to); +- g_mime_object_set_header (GMIME_OBJECT (reply), +- "References", references); ++ if (!reply) ++ continue; + + show_reply_headers (reply); + +-- +1.7.5.4 +